diff --git a/modules/mesh-delivery-contracts/go/seats/nodebuildgo/contract.go b/modules/mesh-delivery-contracts/go/seats/nodebuildgo/contract.go index 0e554b75d..047c71bef 100644 --- a/modules/mesh-delivery-contracts/go/seats/nodebuildgo/contract.go +++ b/modules/mesh-delivery-contracts/go/seats/nodebuildgo/contract.go @@ -69,7 +69,7 @@ func VerbDescription(verb string) string { case VerbResume: return "Take asks again on this node." case VerbDrop: - return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended dropped when the bus gives it, one running is cancelled; both end the step dropped, naming who dropped it and why. Writes dropped. in the pauses state; the build module removes the key when it has acted." + return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended when the bus gives it, one running is cancelled; both end the step could not run, its why naming the drop, who asked it and why, never an outcome of its own (one way for an ask that never ran; design 47 H2 H-A-401). Writes dropped. in the pauses state; the build module removes the key when it has acted." case VerbKeptArtifact: return "The one build this node keeps instead of storing it through the seat oci-artifact-registry: the new build of that seat's holder, when the running holder refused or did not answer the store (design 47 *The artifact store's holder takes its own new build even when its seat is the one broken*). Answers where the bytes are, as an object by their digest on the bus (the old objects form, ADR 0619 §2), never in the answer; the node-engine checks what it fetched against the digest and applies nothing that differs. A module that claims no oci-artifact-registry is refused by name, so a store outage never becomes a delivery from build nodes; so is a build this node no longer keeps, or keeps under another digest." case VerbSteps: diff --git a/modules/mesh-delivery-contracts/go/seats/nodebuildimage/contract.go b/modules/mesh-delivery-contracts/go/seats/nodebuildimage/contract.go index a9f455217..efce6a6d9 100644 --- a/modules/mesh-delivery-contracts/go/seats/nodebuildimage/contract.go +++ b/modules/mesh-delivery-contracts/go/seats/nodebuildimage/contract.go @@ -68,7 +68,7 @@ func VerbDescription(verb string) string { case VerbResume: return "Take asks again on this node." case VerbDrop: - return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended dropped when the bus gives it, one running is cancelled; both end the step dropped, naming who dropped it and why. Writes dropped. in the pauses state; the build module removes the key when it has acted." + return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended when the bus gives it, one running is cancelled; both end the step could not run, its why naming the drop, who asked it and why, never an outcome of its own (one way for an ask that never ran; design 47 H2 H-A-401). Writes dropped. in the pauses state; the build module removes the key when it has acted." case VerbKeptArtifact: return "The one build this node keeps instead of storing it through the seat oci-artifact-registry: the new build of that seat's holder, when the running holder refused or did not answer the store (design 47 *The artifact store's holder takes its own new build even when its seat is the one broken*). Answers where the bytes are, as an object by their digest on the bus (the old objects form, ADR 0619 §2), never in the answer; the node-engine checks what it fetched against the digest and applies nothing that differs. A module that claims no oci-artifact-registry is refused by name, so a store outage never becomes a delivery from build nodes; so is a build this node no longer keeps, or keeps under another digest." case VerbSteps: diff --git a/modules/mesh-delivery-contracts/go/seats/nodebuildnode/contract.go b/modules/mesh-delivery-contracts/go/seats/nodebuildnode/contract.go index 5ad230739..1460a4cc9 100644 --- a/modules/mesh-delivery-contracts/go/seats/nodebuildnode/contract.go +++ b/modules/mesh-delivery-contracts/go/seats/nodebuildnode/contract.go @@ -69,7 +69,7 @@ func VerbDescription(verb string) string { case VerbResume: return "Take asks again on this node." case VerbDrop: - return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended dropped when the bus gives it, one running is cancelled; both end the step dropped, naming who dropped it and why. Writes dropped. in the pauses state; the build module removes the key when it has acted." + return "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended when the bus gives it, one running is cancelled; both end the step could not run, its why naming the drop, who asked it and why, never an outcome of its own (one way for an ask that never ran; design 47 H2 H-A-401). Writes dropped. in the pauses state; the build module removes the key when it has acted." case VerbKeptArtifact: return "The one build this node keeps instead of storing it through the seat oci-artifact-registry: the new build of that seat's holder, when the running holder refused or did not answer the store (design 47 *The artifact store's holder takes its own new build even when its seat is the one broken*). Answers where the bytes are, as an object by their digest on the bus (the old objects form, ADR 0619 §2), never in the answer; the node-engine checks what it fetched against the digest and applies nothing that differs. A module that claims no oci-artifact-registry is refused by name, so a store outage never becomes a delivery from build nodes; so is a build this node no longer keeps, or keeps under another digest." case VerbSteps: diff --git a/modules/mesh-delivery-contracts/parts/build-step.json b/modules/mesh-delivery-contracts/parts/build-step.json index 401d04597..49f33cfcd 100644 --- a/modules/mesh-delivery-contracts/parts/build-step.json +++ b/modules/mesh-delivery-contracts/parts/build-step.json @@ -83,7 +83,7 @@ }, { "name": "drop", - "description": "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended dropped when the bus gives it, one running is cancelled; both end the step dropped, naming who dropped it and why. Writes dropped. in the pauses state; the build module removes the key when it has acted.", + "description": "End an ask this node holds for a caller that no longer waits for it: a step not yet running is ended when the bus gives it, one running is cancelled; both end the step could not run, its why naming the drop, who asked it and why, never an outcome of its own (one way for an ask that never ran; design 47 H2 H-A-401). Writes dropped. in the pauses state; the build module removes the key when it has acted.", "input": { "type": "object", "properties": { diff --git a/modules/mesh-delivery-sdk/steprun/pull_poison_test.go b/modules/mesh-delivery-sdk/steprun/pull_poison_test.go index 3017a1663..4af6d6aa7 100644 --- a/modules/mesh-delivery-sdk/steprun/pull_poison_test.go +++ b/modules/mesh-delivery-sdk/steprun/pull_poison_test.go @@ -229,6 +229,10 @@ func TestAnEndedPipelineStepIsSaidAndAcknowledged(t *testing.T) { switch c { case "dropped": want, needs, lacks = sdkstep.OutcomeCouldNotRun, "", "" + // H-A-401: the drop verb's description says the end it makes. + if d := nodebuildgo.VerbDescription(nodebuildgo.VerbDrop); !strings.Contains(d, "could not run, its why naming the drop") { + t.Errorf("the drop verb is described %q, not as ending its step could not run", d) + } case "declined in its run": needs, lacks = "", "the toolchain" }