Assigner tests: hold putInto's writes one at a time
The composition step starts its machines' runs side by side, and each may raise assignment-unlisted into the test's map: unguarded, the unit suite crashed now and then with concurrent map writes. Only the test raced; the running module writes the bus's findings state. Builds: design 47 H §774
This commit is contained in:
@@ -19,6 +19,7 @@ import (
|
|||||||
"runtime"
|
"runtime"
|
||||||
"slices"
|
"slices"
|
||||||
"strings"
|
"strings"
|
||||||
|
"sync"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
@@ -203,11 +204,17 @@ func (w *watchKV) Keys(context.Context, ...jetstream.WatchOpt) ([]string, error)
|
|||||||
return nil, jetstream.ErrNoKeysFound
|
return nil, jetstream.ErrNoKeysFound
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// putIntoMu holds putInto's writes one at a time: the composition step starts its machines' runs side by side, and each may
|
||||||
|
// raise a finding into the same map.
|
||||||
|
var putIntoMu sync.Mutex
|
||||||
|
|
||||||
// putInto is an assign.Findings Put that keeps each finding in into, as the finding writer would, by its key and its words.
|
// putInto is an assign.Findings Put that keeps each finding in into, as the finding writer would, by its key and its words.
|
||||||
func putInto(into map[string][]byte) func(mcseat.Finding) error {
|
func putInto(into map[string][]byte) func(mcseat.Finding) error {
|
||||||
return func(f mcseat.Finding) error {
|
return func(f mcseat.Finding) error {
|
||||||
raw, err := json.Marshal(f)
|
raw, err := json.Marshal(f)
|
||||||
|
putIntoMu.Lock()
|
||||||
into[views.FindingKey(f.Scope, f.ID, f.Kind)] = raw
|
into[views.FindingKey(f.Scope, f.ID, f.Kind)] = raw
|
||||||
|
putIntoMu.Unlock()
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user