From 4613300bcddfd9fa994960a15c534396b9ad7501 Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 20 Nov 2026 03:38:52 +0100 Subject: [PATCH] A5, A6: a want names the newest version released whose pipeline passed, held for nothing else MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The want rule is written again (internal/assign Wants): for every node the module is assigned to, the want names the version, the pipeline and the mover's rank kept for the module on the placement's branch from the runner's pipeline-ended; a put owns its node's want as before. The state written keeps per module and branch the newest passed version, by compare-and-set on a newer version: a failed pipeline, a mover whose required step failed, an older version, the same one again and a run on request keep nothing; a run's end drops its candidate graph (H-A-58). group-ended is no longer heard. The old holds go with their code, findings, asks and tests: the canary and step, every provider healthy, the grant, the composition and reader capabilities, the provisions (the provisioner's read, its findings), the served verbs, the bus state, rule 2 (the held fingerprint, its hold and restore asks, its lift and conditions), the neither list, the network hold and A-428's exceptions (H-A-55). The record yes stays as the node-engine's have asks it. A want names no composition, so the backup ask is bound to the build. The callers API's call sites go (H-A-66): the seat list's callers, the first-view callers lists in the manifest, the step asker judgement, the enrolment caller read locally. The assigner's revision pins go whole with the gate's pin events (H-A-86): a revision not current is removed when one ceases to be current and at the start. Builds: design 47 H §750, §752, §764, §765 (assigner part); H-A-37, H-A-55, H-A-58, H-A-66, H-A-86 Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy --- .../cmd/mesh-delivery-assigner/compositionstep.go | 2 +- .../cmd/mesh-delivery-assigner/compositionstep_test.go | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep.go b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep.go index ab2c8fd9..fb8a4aa7 100644 --- a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep.go +++ b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep.go @@ -124,7 +124,7 @@ func (c *compositionSteps) say1(ctx context.Context, id string, run meshwants.St stopWait() }() phase := &stepPhase{phase: meshwants.StepProgressEventPhaseFetch} - stop := c.sayProgress(id, run.Asker, phase) + stop := c.sayProgress(id, "", phase) // no asker known: the callers lists go (design 47 H §752, H-A-66) o := how(context.WithValue(ctx, phaseKey{}, phase), id, run) stop() if ctx.Err() != nil { diff --git a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep_test.go b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep_test.go index ee2541c1..48dcfbfb 100644 --- a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep_test.go +++ b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/compositionstep_test.go @@ -96,8 +96,7 @@ func TestARunningCompositionStepSaysItsProgress(t *testing.T) { <-release return stepOutcome{Outcome: meshwants.StepEndedOutcomePassed} }} - // A11/AC1 (design 47 H §752, H-A-88): with no callers in mesh-wants, the progress names the asker the step run carries. - body, _ := json.Marshal(meshwants.StepRun{Pipeline: "main.4", Step: meshwants.StepRunStepComposition, Module: "m", Branch: "main", Asker: "mesh-pipeline-runner"}) + body, _ := json.Marshal(meshwants.StepRun{Pipeline: "main.4", Step: meshwants.StepRunStepComposition, Module: "m", Branch: "main"}) if !c.take(context.Background(), "ask-1", body) { t.Fatal("the composition step is not taken") } @@ -111,7 +110,7 @@ func TestARunningCompositionStepSaysItsProgress(t *testing.T) { said.mu.Lock() p, ok := said.said[progress].(meshwants.StepProgressEvent) said.mu.Unlock() - if !ok || p.Ask != "ask-1" || p.Asker != "mesh-pipeline-runner" || p.Phase != meshwants.StepProgressEventPhaseRun || !p.At.Equal(at) || + if !ok || p.Ask != "ask-1" || p.Asker != "" || p.Phase != meshwants.StepProgressEventPhaseRun || !p.At.Equal(at) || len(p.Shared) != 1 || p.Shared[0].Ask != "run-1" { // the runs the step waits on (§723) t.Fatalf("step-progress %+v", p) }