From 517a4b3cf1b21444f81ba4ca7c86d2ef9c34ce97 Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 20 Nov 2026 20:05:52 +0100 Subject: [PATCH] mesh-delivery-indexer: a pin is the version the registry published for the package's path MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit At main.39 every importer of a nested package was pinned to the release number of the module holding it (v0.1.97 of the builder for its package builds), and the Go seat found no tag /v0.1.97. A Go package's version is its tag: the pin is now the newest version the registry published for that package path (the seats' published, kept in the package's series), never a module's release; a package the registry never published stays unpinned. Builds: design 47 H H-A-183, H-A-167, G §370 --- .../internal/index/imports_test.go | 36 ++++++++++----- .../internal/index/toolchains.go | 8 ++-- .../internal/index/toolchains_test.go | 12 +++-- .../internal/index/versions.go | 45 +++++++++---------- 4 files changed, 60 insertions(+), 41 deletions(-) diff --git a/modules/mesh-delivery-indexer/internal/index/imports_test.go b/modules/mesh-delivery-indexer/internal/index/imports_test.go index 0bcf5888..9752b6f0 100644 --- a/modules/mesh-delivery-indexer/internal/index/imports_test.go +++ b/modules/mesh-delivery-indexer/internal/index/imports_test.go @@ -123,9 +123,21 @@ func TestImportsReportedMoveTheFingerprintOnlyWithAnImportedPackage(t *testing.T moved.Fp2, before.Fp2, moved.Inputs2.ImportForm, moved.Packages) } - // mesh-sdk releases 0.1.20: the import form's fingerprint takes the pin too and moves, once (H-A-172). + // mesh-sdk's module releases 0.1.97 while the registry has published nothing of its Go package: the module's release + // number is never the package's pin (H-A-183), so avahi stays unpinned and where it was. ix.Versions = newMem() - ix.Versions.(*memStore).put(meshcatalog.VersionsByModuleVersionKey("mesh-sdk", "0.1.20"), []byte(`{}`)) + ix.Versions.(*memStore).put(meshcatalog.VersionsByModuleVersionKey("mesh-sdk", "0.1.97"), []byte(`{}`)) + if err := ix.Recompute(ctx); err != nil { + t.Fatal(err) + } + if m, _ := moduleOf(t, mods, "avahi"); m.Fp2 != moved.Fp2 || m.Packages[meshSDK] != "" { + t.Fatalf("after mesh-sdk's module release alone: fp2 %q (was %q), versions %v; want it unpinned where it was", m.Fp2, moved.Fp2, m.Packages) + } + // The registry publishes its Go package at 0.1.20, another version than the module's release: the import form's + // fingerprint takes that pin and moves, once (H-A-172, H-A-183). + if _, err := ix.HearVersion(ctx, HeardVersion{Package: "mesh-sdk/go", Seat: "go-package-registry", Version: "0.1.20", Commit: c3, GoModule: meshSDK, Published: true}); err != nil { + t.Fatal(err) + } for range 2 { if err := ix.Recompute(ctx); err != nil { t.Fatal(err) @@ -283,17 +295,21 @@ func anAcceptedSeriesPinsItsNewest(t *testing.T) { if pinned.Fp2 == before.Fp2 || pinned.Packages[meshSDK] != "v0.1.15" { t.Fatalf("after 0.1.15: fp2 %q (was %q), versions %v; want moved by c3's announce, pinned to v0.1.15", pinned.Fp2, before.Fp2, pinned.Packages) } - if m := step("0.2.0 published from c1", hear("0.2.0", c1)); m.Fp2 != pinned.Fp2 || m.Packages[meshSDK] != "v0.1.15" { - t.Errorf("a publish of a series avahi does not accept moved it: %q %v", m.Fp2, m.Packages) + // 0.2.0 published, of a series avahi does not accept: the pin is the newest version the registry published for the + // package's path, an accepted series' older version never standing over it (H-A-167, H-A-183), and the pin moves the + // fingerprint (H-A-172). + newest := step("0.2.0 published from c1", hear("0.2.0", c1)) + if newest.Fp2 == pinned.Fp2 || newest.Packages[meshSDK] != "v0.2.0" { + t.Errorf("a newer publish of another series left avahi on its accepted series' older version: %q %v", newest.Fp2, newest.Packages) } - if m := step("trunk at c2", trunk(c2)); m.Fp2 != pinned.Fp2 || m.Packages[meshSDK] != "v0.1.15" { - t.Errorf("a trunk merge moved avahi off its accepted series' newest: %q %v", m.Fp2, m.Packages) + if m := step("trunk at c2", trunk(c2)); m.Fp2 != newest.Fp2 || m.Packages[meshSDK] != "v0.2.0" { + t.Errorf("a trunk merge moved avahi off the newest published version: %q %v", m.Fp2, m.Packages) } - // mesh-sdk releases 0.1.20: an accepted series' older version never stands over a newer release (H-A-167). + // mesh-sdk's module releases 0.3.0: a module's release number is never a package's pin (H-A-183). ix.Versions = newMem() - ix.Versions.(*memStore).put(meshcatalog.VersionsByModuleVersionKey("mesh-sdk", "0.1.20"), []byte(`{}`)) - if m := step("0.1.20 released", func() error { return nil }); m.Packages[meshSDK] != "v0.1.20" { - t.Errorf("a newer release left avahi on its series' older version: %v", m.Packages) + ix.Versions.(*memStore).put(meshcatalog.VersionsByModuleVersionKey("mesh-sdk", "0.3.0"), []byte(`{}`)) + if m := step("0.3.0 released", func() error { return nil }); m.Packages[meshSDK] != "v0.2.0" { + t.Errorf("a module's release pinned its package: %v", m.Packages) } } diff --git a/modules/mesh-delivery-indexer/internal/index/toolchains.go b/modules/mesh-delivery-indexer/internal/index/toolchains.go index f3b72e2f..ca7cf416 100644 --- a/modules/mesh-delivery-indexer/internal/index/toolchains.go +++ b/modules/mesh-delivery-indexer/internal/index/toolchains.go @@ -218,8 +218,8 @@ func (ix *Indexer) recomputeLocked(ctx context.Context, overlay map[string]meshc ix.logf("no fingerprint is written by this pass: %v", err) return fmt.Errorf("no fingerprint is written: %w", err) } - series := ix.SeriesAll(ctx) // each package's series, the newest a user accepting it takes (DLV-I6) - released := ix.releasedOf(ctx) // each module's newest released version, what a package is pinned to (H-A-161) + series := ix.SeriesAll(ctx) // each package's series, the newest a user accepting it takes (DLV-I6) + released := publishedOf(series) // each Go package's newest published version by its path, what it is pinned to (H-A-183) type result struct { fp, none string tcs map[string]meshcatalog.ToolchainUsed // by language, when there is a fingerprint @@ -299,7 +299,7 @@ func (ix *Indexer) recomputeLocked(ctx context.Context, overlay map[string]meshc r.fp, r.none = f.fp, f.none if r.fp != "" { // a pin is a released version, never a commit (H-A-161), and the version line's fingerprint takes it (H-A-167) - r.fp, r.pkgs = pinnedOf(f, held, released) + r.fp, r.pkgs = pinnedOf(f, released) r.tcs = toolchainsUsed(toolchains) } } @@ -518,7 +518,7 @@ func stillComputed(module string, kept meshcatalog.ModulesByModuleValueInputs2, if f.none != "" || f.fp == "" { return "", nil, false } - fp, pkgs := pinnedOf(f, held, released) + fp, pkgs := pinnedOf(f, released) return fp, pkgs, fp == k.held.Fp2 } diff --git a/modules/mesh-delivery-indexer/internal/index/toolchains_test.go b/modules/mesh-delivery-indexer/internal/index/toolchains_test.go index 281540a7..6beb739a 100644 --- a/modules/mesh-delivery-indexer/internal/index/toolchains_test.go +++ b/modules/mesh-delivery-indexer/internal/index/toolchains_test.go @@ -805,17 +805,23 @@ func TestAModuleKeepsTheToolchainsItsFingerprintWasComputedWith(t *testing.T) { t.Fatal("a release whose re-pin failed was acknowledged") } mods.keysErr = nil + // The registry published mesh-sdk's Go package at 0.1.18, not at the module's release number 0.1.20: the pin is the + // version the registry published for the package's path (H-A-183). + ix.Packages = newMem() + if _, err := ix.HearVersion(context.Background(), HeardVersion{Package: "mesh-sdk/go", Seat: "go-package-registry", Version: "0.1.18", Commit: strings.Repeat("1", 40), GoModule: sdk, Published: true}); err != nil { + t.Fatal(err) + } if err := ix.HearPackagePublished(context.Background(), release); err != nil { t.Fatal(err) } ix.Revisions = revisions - if a, _ := moduleOf(t, mods, "avahi"); a.Fp2 == first.Fp2 || a.Fp2 == "" || !reflect.DeepEqual(a.Packages, map[string]string{sdk: "v0.1.20"}) { - t.Fatalf("after mesh-sdk's release: fp2 %q (was %q) packages %v, want a new fingerprint pinned to v0.1.20", a.Fp2, first.Fp2, a.Packages) + if a, _ := moduleOf(t, mods, "avahi"); a.Fp2 == first.Fp2 || a.Fp2 == "" || !reflect.DeepEqual(a.Packages, map[string]string{sdk: "v0.1.18"}) { + t.Fatalf("after mesh-sdk's release: fp2 %q (was %q) packages %v, want a new fingerprint pinned to v0.1.18", a.Fp2, first.Fp2, a.Packages) } if o, _ := moduleOf(t, mods, "mesh-tools"); o.Fp2 != tools.Fp2 { t.Errorf("a re-pin moved mesh-tools, which holds no package of mesh-sdk: %q (was %q)", o.Fp2, tools.Fp2) } - second := sdkMerge(strings.Repeat("2", 40), "tree-sdk-2", "v0.1.20") + second := sdkMerge(strings.Repeat("2", 40), "tree-sdk-2", "v0.1.18") if second.Fp2 == first.Fp2 { t.Errorf("a mesh-sdk trunk merge kept avahi's fingerprint %q", first.Fp2) } diff --git a/modules/mesh-delivery-indexer/internal/index/versions.go b/modules/mesh-delivery-indexer/internal/index/versions.go index 1fcae613..2bba22d2 100644 --- a/modules/mesh-delivery-indexer/internal/index/versions.go +++ b/modules/mesh-delivery-indexer/internal/index/versions.go @@ -366,42 +366,39 @@ func isFloor(raw []byte) bool { return json.Unmarshal(raw, &v) == nil && len(v.Artifacts) == 0 } -// releasedOf is the newest released version of each module the state versions keeps (§349; design 47 H-A-161), by module; -// nil when the indexer keeps no such state or it cannot be listed, said. -func (ix *Indexer) releasedOf(ctx context.Context) map[string]string { - if ix.Versions == nil { - return nil - } - all, err := ix.Versions.Keys(ctx) - if err != nil { - ix.logf("versions: the state cannot be listed, so no package is pinned by this pass: %v", err) - return nil - } +// publishedOf is the newest version the registry published of each Go package, by its path (design 47 H-A-183, G §370): +// what the seats' published said, kept in the package's series (HearVersion), across every series; none for a package +// the registry never published. A Go package's version is its tag, so a module's release number is never one. +func publishedOf(series map[string]SeriesPackage) map[string]string { out := map[string]string{} - for _, k := range all { - m, v, ok := meshcatalog.ParseVersionsByModuleVersionKey(k) - if _, parts := versionParts(v); !ok || !parts { + for _, s := range series { + if s.GoModule == "" || s.Newest == nil { continue } - if cur, has := out[m]; !has || compareVersions(v, cur) > 0 { - out[m] = v + v := strings.TrimPrefix(s.Newest.Version, "v") + if _, ok := versionParts(v); !ok { + continue + } + if cur, has := out[s.GoModule]; !has || compareVersions(v, cur) > 0 { + out[s.GoModule] = v } } return out } // releasedPins are a module's pins (its catalog entry's packages, which the builder builds it against) from the versions its -// fingerprint was computed with (design 47 H-A-161, G §370): a package the held module holding it has released is pinned -// to that module's newest released version, as Go names it (v); a version already in that form (an accepted -// series' newest, DLV-I6) stands; any other, a commit, is no pin: its package is kept with no version, so its kind-1 edge -// stands (H §746) and no build is made against a commit. nil for none. -func releasedPins(versions sdkstep.PackageVersions, held map[string]meshcatalog.ModulesByModuleValue, released map[string]string) sdkstep.PackageVersions { +// fingerprint was computed with (design 47 H-A-161, H-A-183, G §370): a package the registry published is pinned to the +// newest version it published for that package's path (published, publishedOf), as Go names it (v); an accepted +// series' version (DLV-I6) stands only while no newer one is published (H-A-167); any other, a commit, is no pin: its +// package is kept with no version, so its kind-1 edge stands (H §746) and its build waits for the publish (H-A-165). +// nil for none. +func releasedPins(versions sdkstep.PackageVersions, published map[string]string) sdkstep.PackageVersions { if len(versions) == 0 { return nil } out := sdkstep.PackageVersions{} for p, v := range versions { - rel := released[moduleOfKey(fingerprint.HolderOf(p, held))] + rel := published[p] series := sdkstep.PackageSemver.MatchString(v) _, plain := versionParts(strings.TrimPrefix(v, "v")) switch { @@ -420,8 +417,8 @@ func releasedPins(versions sdkstep.PackageVersions, held map[string]meshcatalog. // form's fingerprint takes them (design 47 H-A-167, H-A-172; ADR 0573 §4) and a re-pin moves it, the module a mover // built again against the release; a fingerprint with no pin is the form's as it is. The held fingerprint of a build that // stands is kept while its pins are the ones it was built with, else its import form takes the new pins. -func pinnedOf(f form, held map[string]meshcatalog.ModulesByModuleValue, released map[string]string) (string, sdkstep.PackageVersions) { - pins := releasedPins(f.versions, held, released) +func pinnedOf(f form, published map[string]string) (string, sdkstep.PackageVersions) { + pins := releasedPins(f.versions, published) if f.stands { if maps.Equal(f.built, map[string]string(pins)) { return f.fp, pins