diff --git a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/pass.go b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/pass.go index 266ba14f..9fb3a895 100644 --- a/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/pass.go +++ b/modules/mesh-delivery-assigner/cmd/mesh-delivery-assigner/pass.go @@ -335,20 +335,26 @@ func (p *passer) wants(ctx context.Context) { branches = []string{g.branch} } if fp != "" && !p.ends.mayWant(name, fp, branches, wantedOf[name]) { - if !runnerFirstStart(name, manifests, p.w.runningNow()) { + if !runnerFirstStart(name, manifests, p.w.runningNow()) && !manifests[name].ClaimsSeat(meshcatalog.Seat) { none := assign.Outcome{Rules: noPipelineRules(g.nodes, name, fp, branches)} p.sayNoWant(name, g.nodes, wantedOf[name], none) p.sayWhy(ctx, name, g.nodes, wantWhy{Branch: g.branch, Fp: fp, Step: whyNoPipeline}, wantedOf[name], &none, nil) return } // The first start of the pipeline runner (design 47 G A-428): no runner runs to pass its pipeline, so its want is - // written from the trunk's entry by the other rules, and said once. - if key := "runner-first-start " + name + "@" + fp; !p.skipped[key] { + // written from the trunk's entry by the other rules, and said once. So is the holder of mesh-catalog's: every + // pipeline runs on a revision it took in, and a revision naming a newer one is taken in only by that one (§16, + // G-5's whole test of indexer and assigner: the new indexer is wanted and granted, starts, and takes it in). + if key := "no-pipeline-start " + name + "@" + fp; !p.skipped[key] { if p.skipped == nil { p.skipped = map[string]bool{} } p.skipped[key] = true - p.logf("%s at %s is wanted with no passed pipeline: it claims the seat %s and no module holding that seat runs on any node, so none can pass one (design 47 G A-428)", name, shortHex(fp), mpr.Seat) + if manifests[name].ClaimsSeat(meshcatalog.Seat) { + p.logf("%s at %s is wanted with no passed pipeline: it claims the seat %s, every pipeline runs on a revision it took in, and a revision naming it is taken in only by it (design 47 G §16)", name, shortHex(fp), meshcatalog.Seat) + } else { + p.logf("%s at %s is wanted with no passed pipeline: it claims the seat %s and no module holding that seat runs on any node, so none can pass one (design 47 G A-428)", name, shortHex(fp), mpr.Seat) + } } } // A dependent's new version waits for its dependency's newest released version to be delivered (§376, A-189).