From 8e5e5dbb4232e6663991344adfe7271d5b1d80c3 Mon Sep 17 00:00:00 2001 From: jochen Date: Fri, 20 Nov 2026 02:36:37 +0100 Subject: [PATCH] seatgen: an identifier splits on ':' too, so want:version is a Go constant The node-engine seat's enum value want:version must yield a parseable Go constant; ':' splits as '-', '_', '.' and a space do. No existing generated output changes (the generator's check of mesh-delivery-contracts is unchanged). Builds: design 47 H lead answer H-A-64 Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy --- modules/mesh-delivery-sdk/seatgen/layout_test.go | 11 +++++++++++ modules/mesh-delivery-sdk/seatgen/load.go | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/modules/mesh-delivery-sdk/seatgen/layout_test.go b/modules/mesh-delivery-sdk/seatgen/layout_test.go index 144b73e3..140ee906 100644 --- a/modules/mesh-delivery-sdk/seatgen/layout_test.go +++ b/modules/mesh-delivery-sdk/seatgen/layout_test.go @@ -373,3 +373,14 @@ func TestBodiesAreTypesAndAcceptedKindsRideStreams(t *testing.T) { t.Errorf("index.js lacks the delivery stream's subject:\n%s", js) } } + +// TestAnIdentifierSplitsOnEverySeparator is H-A-64's check: an enum value such as `want:version` yields a parseable +// Go identifier, `:` splitting as `-`, `_`, `.` and a space do. +func TestAnIdentifierSplitsOnEverySeparator(t *testing.T) { + for name, want := range map[string]string{"want:version": "WantVersion", "publish-part": "PublishPart", + "step_id": "StepID", "a.b c": "ABC", "cap-mib": "CapMiB"} { + if got := ident(name); got != want { + t.Errorf("ident(%q) = %q, want %q", name, got, want) + } + } +} diff --git a/modules/mesh-delivery-sdk/seatgen/load.go b/modules/mesh-delivery-sdk/seatgen/load.go index 62c42967..9a83d4b6 100644 --- a/modules/mesh-delivery-sdk/seatgen/load.go +++ b/modules/mesh-delivery-sdk/seatgen/load.go @@ -182,7 +182,7 @@ func pkgName(name string) string { return strings.ReplaceAll(name, "-", "") } // PreviewWritten, local-name → LocalName, id → ID. func ident(name string) string { var b strings.Builder - for _, w := range strings.FieldsFunc(name, func(r rune) bool { return r == '-' || r == '_' || r == '.' || r == ' ' }) { + for _, w := range strings.FieldsFunc(name, func(r rune) bool { return r == '-' || r == '_' || r == '.' || r == ' ' || r == ':' }) { switch w { case "id": b.WriteString("ID")