The assigner and the indexer's hold count a bootstrapped seat as read (issue 1966)
mesh/delivery merged: source.main moved to novox/mesh-delivery@7f412185525e
mesh/delivery-group group fix/1966-seat-reads-bootstrap merged: every member is merged
mesh/check failed (2): mesh-delivery-checker: no published of the tagged version of go-sdk of mesh-delivery…; and 1 more | ee6fd92b4d1a on 7f412185525e
mesh/delivery merged: source.main moved to novox/mesh-delivery@7f412185525e
mesh/delivery-group group fix/1966-seat-reads-bootstrap merged: every member is merged
mesh/check failed (2): mesh-delivery-checker: no published of the tagged version of go-sdk of mesh-delivery…; and 1 more | ee6fd92b4d1a on 7f412185525e
Every reader of the seat list holds the bootstrapped seats from its start (ADR 0636 §2), so a manifest naming one is read by every node-engine whatever its statement names. graph.MissingReads, in the Delivery domain's SDK, is the one rule both holds judge with; mesh-sdk is not changed. ace's engine states no seat, so the want of the node-engine's own build 0bd8cbad (needing mesh-catalog) and of restic (needing node-backup) were held on ace: the engine that would state them could not be delivered. The indexer's hold judges only mesh-wide reads today, so its verdicts do not change; it takes the rule so the two stay one. Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5
This commit is contained in:
@@ -18,6 +18,25 @@ func TestGraphEdges(t *testing.T) {
|
||||
t.Run("a node's value", nodeValues)
|
||||
t.Run("a reader of the seat list waits for its holder", readersOfTheSeatList)
|
||||
t.Run("a verb is served by a running healthy have of the node-engine contract", servedByHaves)
|
||||
// ADR 0636 §2, issue 1966: a need of a bootstrapped seat is read by every engine whatever its statement names; a seat
|
||||
// not bootstrapped and a word stay missing, and an engine stating none is read as the baseline.
|
||||
t.Run("a bootstrapped seat is read by every engine", func(t *testing.T) {
|
||||
stated := []string{"word:claims", "word:invokes"}
|
||||
for _, c := range []struct {
|
||||
name string
|
||||
needs, stated []string
|
||||
want []string
|
||||
}{
|
||||
{"mesh-catalog and node-backup", []string{"seat:mesh-catalog", "seat:node-backup", "word:invokes"}, stated, nil},
|
||||
{"a seat not bootstrapped", []string{"seat:mesh-catalog", "seat:mesh-vault"}, stated, []string{"seat:mesh-vault"}},
|
||||
{"a word", []string{"seat:node-engine", "word:zone"}, stated, []string{"word:zone"}},
|
||||
{"the baseline", []string{"seat:mesh-catalog", "form:seat-reach"}, nil, []string{"form:seat-reach"}},
|
||||
} {
|
||||
if got := MissingReads(c.needs, c.stated); !slices.Equal(got, c.want) {
|
||||
t.Errorf("%s: missing %v, want %v", c.name, got, c.want)
|
||||
}
|
||||
}
|
||||
})
|
||||
fp := "src2:" + strings.Repeat("b", 64)
|
||||
node := func(repository, path string, edit func(*Node)) Node {
|
||||
n := Node{FP: fp, Repository: repository, Path: path}
|
||||
|
||||
@@ -0,0 +1,37 @@
|
||||
package graph
|
||||
|
||||
import (
|
||||
"slices"
|
||||
"strings"
|
||||
"sync"
|
||||
|
||||
"git.novox.be/novox/mesh-sdk/go/catalogue"
|
||||
"git.novox.be/novox/mesh-sdk/go/seatlist"
|
||||
)
|
||||
|
||||
// bootstrappedReads are the reader capabilities `seat:<seat>` of the bootstrapped seats: the embedded files' own, so
|
||||
// computed once.
|
||||
var bootstrappedReads = sync.OnceValue(func() []string {
|
||||
var out []string
|
||||
for _, d := range seatlist.Bootstrapped() {
|
||||
out = append(out, catalogue.ReadSeat+d.Seat)
|
||||
}
|
||||
return out
|
||||
})
|
||||
|
||||
// MissingReads is catalogue.MissingManifestReads with every need of a bootstrapped seat counted as read (novox/hq ADR 0614
|
||||
// §4, ADR 0636 §2): every reader of the seat list holds the bootstrapped seats from its start, before it has read the list,
|
||||
// so a manifest naming one is read by every node-engine whatever its statement names. Without it an engine whose statement
|
||||
// was made before its list was in use states no seat, and the node-engine's own build naming mesh-catalog is held on the
|
||||
// very engine that would state it (issue 1966). The assigner's capability hold and the indexer's hold both judge with it,
|
||||
// so the rule is one.
|
||||
func MissingReads(needs, stated []string) []string {
|
||||
boot := bootstrappedReads()
|
||||
missing := slices.DeleteFunc(catalogue.MissingManifestReads(needs, stated), func(n string) bool {
|
||||
return strings.HasPrefix(n, catalogue.ReadSeat) && slices.Contains(boot, n)
|
||||
})
|
||||
if len(missing) == 0 {
|
||||
return nil
|
||||
}
|
||||
return missing
|
||||
}
|
||||
Reference in New Issue
Block a user