From f44442097c4c96e49cccef1c9252e9b435c80b01 Mon Sep 17 00:00:00 2001 From: jochen Date: Sun, 22 Nov 2026 15:54:01 +0100 Subject: [PATCH] mesh-delivery-pipeline: widens-read-bound defaults to 30 s A cold grants-for (one composing a revision's grants the grants part did not keep yet) took 3 to 4 s against the 5 s bound and was cut three times on 2026-11-22; the bound becomes 30 s in the manifest and the code. Builds: design 47 H2 H-A-478 --- .../cmd/mesh-delivery-pipeline/widens.go | 5 +++-- .../cmd/mesh-delivery-pipeline/widens_test.go | 2 +- modules/mesh-delivery-pipeline/manifest_test.go | 3 ++- modules/mesh-delivery-pipeline/module.json | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens.go b/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens.go index 12fef5af3..a9d5bac82 100644 --- a/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens.go +++ b/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens.go @@ -38,8 +38,9 @@ func widenerOf(call func(key string, body any) (json.RawMessage, error), bound t const ( envWidensReadBound = "MESH_RUNNER_WIDENS_READ_BOUND_FILE" envRevisionsKept = "MESH_RUNNER_REVISIONS_KEPT_FILE" - // defaultReadBound is how long one read of widens waits for its answer: a few seconds, never the call's 30. - defaultReadBound = 5 * time.Second + // defaultReadBound is how long one read of widens waits for its answer: 30 s, so a cold grants-for (one that composes a + // revision's grants the grants part did not keep yet) is not cut (design 47 H2 H-A-478). + defaultReadBound = 30 * time.Second // defaultRevisionsKept is how many catalog revisions the runner keeps once read; a revision of the catalog graph is some 1.4 MB. defaultRevisionsKept = 6 ) diff --git a/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens_test.go b/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens_test.go index 57c7fea7f..03c9cb009 100644 --- a/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens_test.go +++ b/modules/mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/widens_test.go @@ -115,7 +115,7 @@ func TestWidensSettings(t *testing.T) { kept int ok bool }{ - {"defaults", nil, 5 * time.Second, 6, true}, + {"defaults", nil, 30 * time.Second, 6, true}, {"set", map[string]string{envWidensReadBound: "2s\n", envRevisionsKept: "3\n"}, 2 * time.Second, 3, true}, {"no duration", map[string]string{envWidensReadBound: "5"}, 0, 0, false}, {"no number", map[string]string{envRevisionsKept: "0"}, 0, 0, false}, diff --git a/modules/mesh-delivery-pipeline/manifest_test.go b/modules/mesh-delivery-pipeline/manifest_test.go index 4c3989ad5..07d0dbfad 100644 --- a/modules/mesh-delivery-pipeline/manifest_test.go +++ b/modules/mesh-delivery-pipeline/manifest_test.go @@ -237,7 +237,8 @@ func runSettingsOf(raw []byte) bool { } if len(m.Config) != len(want)+len(words) || m.Config["test-runs-cap-mib"]["maximum"] != float64(64) || m.Config["test-runs-cap-mib"]["default"] != float64(16) || m.Config["pipelines-at-once"]["minimum"] != float64(1) || m.Config["pipelines-at-once"]["maximum"] != float64(8) || - m.Config["pipelines-at-once"]["default"] != float64(1) || m.Config["pipelines-waiting-cap"]["default"] != float64(64) { + m.Config["pipelines-at-once"]["default"] != float64(1) || m.Config["pipelines-waiting-cap"]["default"] != float64(64) || + m.Config["widens-read-bound"]["default"] != "30s" { return false } env := map[string]bool{} diff --git a/modules/mesh-delivery-pipeline/module.json b/modules/mesh-delivery-pipeline/module.json index 3c6a71fa8..e1e2bae21 100644 --- a/modules/mesh-delivery-pipeline/module.json +++ b/modules/mesh-delivery-pipeline/module.json @@ -138,9 +138,9 @@ }, "widens-read-bound": { "type": "string", - "description": "how long one read of a pipeline end's widens (the catalog's revision, the seat holders, the grants part) waits for its answer before it is cut and said could not run, a Go duration such as 5s (design 47 G A-472, A-472a).", + "description": "how long one read of a pipeline end's widens (the catalog's revision, the seat holders, the grants part) waits for its answer before it is cut and said could not run, a Go duration such as 30s (design 47 G A-472, A-472a, H2 H-A-478: long enough that a cold grants-for is not cut).", "trusted": false, - "default": "5s" + "default": "30s" }, "revisions-kept": { "type": "number",