From fa271370364df4ab500e89f0ef8fda2c1263e9c5 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 4 Nov 2026 15:35:22 +0100 Subject: [PATCH] Join: a look at a done build key logs no "kept" narration After the join the builder looks at a done key again whenever a first view is answered late or a package's name is heard (lead's i), and each look's "version kept" narration was written to the build log after the build's end, with no start or end around it. A look at a done key builds nothing: a kept version says nothing new there and stays in the process log only. TestBuilderMakesADoneKeyWithTheDigests failed at about one run in three (kept narrations of tools-go and tools-typescript after the end); 8 of 8 pass. Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig --- modules/mesh-delivery-builder/internal/build/numbers.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/mesh-delivery-builder/internal/build/numbers.go b/modules/mesh-delivery-builder/internal/build/numbers.go index 3455b467..d8b14932 100644 --- a/modules/mesh-delivery-builder/internal/build/numbers.go +++ b/modules/mesh-delivery-builder/internal/build/numbers.go @@ -83,7 +83,9 @@ func (b *Builder) number(ctx context.Context, module string, m delivery.Module, for _, s := range got.Said { b.logf("%s at %s: %s", module, m.FP2, s.Line) // And in the build log (design 51 *The versions*: it says a version was kept, and why), between the build's start and end. - if b.Log != nil { + // A look at a key already done builds nothing and has no start or end: a version kept there says nothing new, and is + // not logged (each later look, a first view answered or a name heard, would add one). + if b.Log != nil && !(done != nil && s.Why == versions.SaidKept) { b.Log(delivery.BuildLogEntry{Event: delivery.BuildSaidEvent, Module: module, FP: m.FP2, Commit: m.Commit, Node: b.Node, At: time.Now().UTC(), Line: s.Line, Why: s.Why}) }