From fcac1fc5d08428c9ef06c86f7ddcc215203da030 Mon Sep 17 00:00:00 2001 From: jochen Date: Sun, 22 Nov 2026 19:37:22 +0100 Subject: [PATCH] H-A-487: prove a listing reads no history when its entries carry no time Review round 1 found the fingerprint guard of the build read unproven: every entry of the 100-key listing carried a time. The listing is now also read with entries that say none, and no history may be read. Builds: design 47 H2 H-A-487 (review round 1 finding) --- modules/mesh-delivery-builder/internal/build/buildread_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/mesh-delivery-builder/internal/build/buildread_test.go b/modules/mesh-delivery-builder/internal/build/buildread_test.go index 37f609133..5602a5874 100644 --- a/modules/mesh-delivery-builder/internal/build/buildread_test.go +++ b/modules/mesh-delivery-builder/internal/build/buildread_test.go @@ -86,6 +86,9 @@ func TestBuilderBuildAnswersAModulesKeysWhole(t *testing.T) { t.Fatalf("100 keys: %d rows, newest %v, %d histories read, note %q; want the 20 newest, no history, the cut said", len(a.Builds), a.Builds[0].Since, histories, a.Note) } big.Entry = func(k string) (json.RawMessage, uint64, time.Time, error) { return many[k], 1, time.Time{}, nil } + if a, err := big.Build("big", ""); err != nil || len(a.Builds) != MostBuilds || histories != 0 { + t.Fatalf("100 keys with no time in their entries: %d rows (%v), %d histories read; want no history read for a listing", len(a.Builds), err, histories) + } if one, err := big.Build("big", fmt.Sprintf("src2:%064x", 7)); err != nil || len(one.Builds) != 1 || !one.Builds[0].Since.Equal(base) || histories != 1 { t.Errorf("one fingerprint with no time in its entry: %+v (%v), %d histories; want its one history read", one, err, histories) }