The assigner, grants and the indexer ask their views again when the bus makes their consumer after a first view (issue 1966, recovery) #184

2026-11-09T01:32:51Z

mesh-tools commented

2026-11-09 01:32:51 +00:00

Recovery fix (instruction recovery-fixes-merge-and-tell), issue 1966 note 110; delivery group fix/1966-views-durable with mesh-sdk (same branch), which merges first: this calls its new EventHub.OnBound and Follower.ConsumerMade.

Change. The three parts that hear through their own hubs register hub.OnBound before hub.Start: the assigner (cmd/mesh-delivery-assigner/views.go, its three followers), the indexer (cmd/mesh-delivery-indexer/views.go, assignments) and grants (cmd/mesh-grants/main.go, its five followers, once).

Test rule bent (rules-are-weighed). No test row here: OnBound fires only inside hub.Start against a real JetStream consumer, and mesh-delivery is over its integration budget (68 of 50). The behaviour is proven at unit level in mesh-sdk; this is wiring only. The reviewer judged it acceptable.

Tests. go vet, go vet -tags integration, go test ./... pass in the three modules against the mesh-sdk head.

Reviewed-by: mesh-code-reviewer@shanks at 173a7654ba

Undo: revert this merge.

https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

Recovery fix (instruction recovery-fixes-merge-and-tell), issue 1966 note 110; delivery group fix/1966-views-durable with mesh-sdk (same branch), which merges first: this calls its new EventHub.OnBound and Follower.ConsumerMade. **Change.** The three parts that hear through their own hubs register hub.OnBound before hub.Start: the assigner (cmd/mesh-delivery-assigner/views.go, its three followers), the indexer (cmd/mesh-delivery-indexer/views.go, assignments) and grants (cmd/mesh-grants/main.go, its five followers, once). **Test rule bent (rules-are-weighed).** No test row here: OnBound fires only inside hub.Start against a real JetStream consumer, and mesh-delivery is over its integration budget (68 of 50). The behaviour is proven at unit level in mesh-sdk; this is wiring only. The reviewer judged it acceptable. **Tests.** go vet, go vet -tags integration, go test ./... pass in the three modules against the mesh-sdk head. Reviewed-by: mesh-code-reviewer@shanks at 173a7654ba613ec10f042838abd1b0bac7ea3462 **Undo:** revert this merge. https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

mesh-tools added 1 commit 2026-11-09 01:32:51 +00:00

The assigner, the indexer and the grants part tell their followers when the bus made their consumer (issue 1966, recovery)

mesh/delivery merged: source.main moved to novox/mesh-delivery@e39ec444bd39

Details

mesh/delivery-group group fix/1966-views-durable merged: every member is merged

Details

mesh/check checking 173a7654ba61 on e39ec444bd39 | novox/mesh-delivery#184 in group fix/1966-views-durable

173a7654ba

A consumer is made from now, so an event said between a first view and the consumer is never delivered; the hub says when the bus made it (EventHub.OnBound) and each follower asks again if behind (Follower.ConsumerMade).

Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i

mesh-tools commented

2026-11-09 01:32:55 +00:00

Delivery novox/mesh-delivery@173a7654ba61 — merged since 2026-11-09T07:04:33Z

Source — source.main moved to novox/mesh-delivery@e39ec444bd. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1966-views-durable: novox/mesh-delivery@173a7654ba, novox/mesh-sdk@38659c3937

composed together: fail — the checker's verdict at the members' heads (603dd79ad282): unit: git.novox.be/novox/mesh-sdk/go/catalogue.TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf

Transitions

2026-11-09 01:32 (new) → proposed (announced): novox/mesh-delivery#184's head announced
2026-11-09 01:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-09 07:04 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@173a7654ba61` — **merged** since 2026-11-09T07:04:33Z **Source** — source.main moved to novox/mesh-delivery@e39ec444bd39. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1966-views-durable`: novox/mesh-delivery@173a7654ba61, novox/mesh-sdk@38659c3937e7 - composed together: fail — the checker's verdict at the members' heads (603dd79ad282): unit: git.novox.be/novox/mesh-sdk/go/catalogue.TestTheResolverForwardsToFixedUpstreamsAndNeverReadsResolvConf **Transitions** - 2026-11-09 01:32 (new) → proposed (announced): novox/mesh-delivery#184's head announced - 2026-11-09 01:32 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-09 07:04 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit e39ec444bd into main

2026-11-09 07:04:32 +00:00

mesh-tools deleted branch fix/1966-views-durable

2026-11-09 07:04:32 +00:00

mesh-tools referenced this pull request

2026-11-09 08:24:19 +00:00

The forge bridge answers a merge made on the forge, so the indexer takes it in without a gate record (issue 1966, recovery) #185

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#184