The checker previews a member whose fetch merged, whatever its later steps ended with #208

Merged
mesh-tools merged 1 commits from fix/checker-preview-after-failed-step into main 2026-11-12 14:34:09 +00:00
Member

Small fix (hq playbook 08), group fix/checker-preview-after-failed-step with mesh-catalog; builds A-286 (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md; issue 1921 note 90; principle 3).

The checker judged no manifest and no composition for a group when any member's step failed after its fetch merged, and said 'its head does not merge or its fetch did not answer'. It now previews from a failed step's answer when its fetch merged; a member stays unpreviewed only when its head does not merge or its fetch did not answer, and the check says which.

Quick fix: this, on main, so G's next try is judged whole. Thorough fix: the same rule in G's checker (join 11, 5fbc366f, the same hunks line for line).

Tests: the 'errors' row and the conflict row's words in TestEveryFailureOfEveryMemberLevelAndTheCompositionIsNamed, each failing without its half.

Reviewed-by: mesh-code-reviewer@shanks at 24d9c6cdf8

https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h

Small fix (hq playbook 08), group fix/checker-preview-after-failed-step with mesh-catalog; builds A-286 (hq 03-DESIGN/01-to-be/47-milestones/G-22-lead-answers-2.md; issue 1921 note 90; principle 3). The checker judged no manifest and no composition for a group when any member's step failed after its fetch merged, and said 'its head does not merge or its fetch did not answer'. It now previews from a failed step's answer when its fetch merged; a member stays unpreviewed only when its head does not merge or its fetch did not answer, and the check says which. Quick fix: this, on main, so G's next try is judged whole. Thorough fix: the same rule in G's checker (join 11, 5fbc366f, the same hunks line for line). Tests: the 'errors' row and the conflict row's words in TestEveryFailureOfEveryMemberLevelAndTheCompositionIsNamed, each failing without its half. Reviewed-by: mesh-code-reviewer@shanks at 24d9c6cdf8d9493f2ae475a60d184f91436f29d7 https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h
mesh-tools added 1 commit 2026-11-12 14:33:01 +00:00
The checker previews a member whose fetch merged, whatever its later steps ended with
mesh/delivery merged: source.main moved to novox/mesh-delivery@a5d710863157
mesh/delivery-group group fix/checker-preview-after-failed-step merged: every member is merged
mesh/check checking 24d9c6cdf8d9 on a5d710863157 | novox/mesh-delivery#208 in group fix/checker-preview-after-failed-step
24d9c6cdf8
A member whose check step errored after its fetch merged was left unpreviewed,
so one failing level hid the manifest validator and the composition from the
check, and the words "its head does not merge or its fetch did not answer"
were wrong for it. The checker now reads the fetch a failed step answers
beside its error and previews the merge from it; only a head that does not
merge or a fetch that did not answer stays unpreviewed, and the check says
which of the two.

Builds: design 47 G A-286 (G-22-lead-answers-2.md at hq 41dd30fe; issue 1921; principle 3)
Quick: this checker on main; thorough: the same rule in G's checker (join 11, J15).

Claude-Session: https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h
Author
Member

Delivery novox/mesh-delivery@24d9c6cdf8d9 — merged since 2026-11-12T14:34:12Z

Source — source.main moved to novox/mesh-delivery@a5d7108631. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/checker-preview-after-failed-step: novox/mesh-catalog@fff3b819d3, novox/mesh-delivery@24d9c6cdf8

Transitions

  • 2026-11-12 14:33 (new) → proposed (announced): novox/mesh-delivery#208's head announced
  • 2026-11-12 14:33 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
  • 2026-11-12 14:34 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@24d9c6cdf8d9` — **merged** since 2026-11-12T14:34:12Z **Source** — source.main moved to novox/mesh-delivery@a5d710863157. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/checker-preview-after-failed-step`: novox/mesh-catalog@fff3b819d383, novox/mesh-delivery@24d9c6cdf8d9 **Transitions** - 2026-11-12 14:33 (new) → proposed (announced): novox/mesh-delivery#208's head announced - 2026-11-12 14:33 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-12 14:34 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.
mesh-tools merged commit a5d7108631 into main 2026-11-12 14:34:09 +00:00
mesh-tools deleted branch fix/checker-preview-after-failed-step 2026-11-12 14:34:10 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#208