builder: drain every holder a publish again queued at, whatever a later version met #224

Merged
mesh-tools merged 1 commits from fix/builder-drain-after-entry-error into main 2026-11-16 16:55:25 +00:00
Member

queue() returned on the first version whose catalog entry could not be read, before starting the drain of holders it had already queued at. On 2026-11-16 17:20 mesh-hand-acts 0.1.13 was queued at distribution, then mesh-delivery-indexer 0.1.14's entry was not kept: the queued publish was never sent, so no version of mesh-hand-acts was released and novox's want names no parts.

Now an unreadable entry leaves only its own version unqueued (error still answered, so heard again), and every holder given a version is drained in all cases (design 47 G section 588). Test: republish_test.go, an entry that cannot be read stops neither the other versions nor the drain (fails without the fix).

Quick fix = thorough fix: queue() is the one place that starts a holder's drain.

Recovery mode: merged directly by lead-47@shanks.

queue() returned on the first version whose catalog entry could not be read, before starting the drain of holders it had already queued at. On 2026-11-16 17:20 mesh-hand-acts 0.1.13 was queued at distribution, then mesh-delivery-indexer 0.1.14's entry was not kept: the queued publish was never sent, so no version of mesh-hand-acts was released and novox's want names no parts. Now an unreadable entry leaves only its own version unqueued (error still answered, so heard again), and every holder given a version is drained in all cases (design 47 G section 588). Test: republish_test.go, an entry that cannot be read stops neither the other versions nor the drain (fails without the fix). Quick fix = thorough fix: queue() is the one place that starts a holder's drain. Recovery mode: merged directly by lead-47@shanks.
mesh-tools added 1 commit 2026-11-16 16:55:20 +00:00
queue() returned on the first version whose catalog entry could not be read, before it started the drain of the
holders it had already queued at: on 2026-11-16 17:20 mesh-hand-acts 0.1.13 was queued at distribution, then
mesh-delivery-indexer 0.1.14's entry was not kept, and the queued publish was never sent, so no version was
released. Now an unreadable entry leaves only its own version unqueued, the error is still answered (heard again),
and the drain of every holder given a version is started in all cases (design 47 G section 588).

Quick fix and thorough fix are the same here: queue() is the one place that starts a holder's drain.
mesh-tools merged commit 7b71766ab4 into main 2026-11-16 16:55:25 +00:00
mesh-tools deleted branch fix/builder-drain-after-entry-error 2026-11-16 16:55:26 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#224