Every reader of the newest catalog revision reads the newest again when it is removed under it (A-487d) #254

Merged
mesh-tools merged 3 commits from fix/newest-readers-again into main 2026-11-19 11:54:41 +00:00
Member

Completes A-487d (hq 61bf1215) after #252: the other readers in the indexer that name the newest revision now go through readNewestOf — entryOf, SeedModulesFrom, SeedEntryHeld, ModuleInNewestView, the versions fill, the outdated tool's trunk read (its failure is now said, not dropped), the indexer_catalog_revision tool with no input, and the verb revision without a kept view and for a watched branch's newest. Reads by number, source or candidate keep failing loudly.

Tests: one table (TestTheNewestRevisionReadersReadAgainWhenTheRevisionIsRemovedUnderThem, 9 subtests) and the same-revision-twice case for Outdated; each case fails without its change (checked by the reviewer). No new test function beyond the table; 191 unit, 12 integration.

Left out (hardening, not asked by the review): RecomputeByHand and kickCatchUp, which read only the newest list.

Reviewed-by: mesh-code-reviewer@shanks at 04500fa29d

https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy

Completes A-487d (hq 61bf1215) after #252: the other readers in the indexer that name the newest revision now go through `readNewestOf` — `entryOf`, `SeedModulesFrom`, `SeedEntryHeld`, `ModuleInNewestView`, the versions fill, the outdated tool's trunk read (its failure is now said, not dropped), the `indexer_catalog_revision` tool with no input, and the verb `revision` without a kept view and for a watched branch's newest. Reads by number, source or candidate keep failing loudly. Tests: one table (`TestTheNewestRevisionReadersReadAgainWhenTheRevisionIsRemovedUnderThem`, 9 subtests) and the same-revision-twice case for `Outdated`; each case fails without its change (checked by the reviewer). No new test function beyond the table; 191 unit, 12 integration. Left out (hardening, not asked by the review): `RecomputeByHand` and `kickCatchUp`, which read only the newest list. Reviewed-by: mesh-code-reviewer@shanks at 04500fa29df15683f7ad681c08fbeb8d0e0194f2 https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
mesh-tools added 3 commits 2026-11-19 11:54:34 +00:00
ModuleInNewestView, SeedEntryHeld, entryOf, SeedModulesFrom, the first fill of the versions, the outdated tool's trunk read and the verb
revision without a kept view use readNewestOf; none of them holds keepMu.

Builds: design 47 G A-487d (hq 61bf1215)
Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
The default read of the tool and the newest revision of a branch other than the trunk use readNewestOf; a read by number keeps
failing loudly. One table covers every reader of the newest revision in the indexer program.

Builds: design 47 G A-487d (hq 61bf1215)
Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
Builds: design 47 G A-487d (hq 61bf1215)
Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
mesh-tools merged commit 1eec825926 into main 2026-11-19 11:54:41 +00:00
mesh-tools deleted branch fix/newest-readers-again 2026-11-19 11:54:41 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_1027_7de55038/c6e6ffa6a785fa71",
"sequence": 10198,
"bytes": 871,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.1027",
"heads": {
"novox/mesh-delivery@254": "1eec825926d6b1fd826563945f57332fd99856c2"
},
"opened": "2026-11-19T11:55:11.162465263Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-delivery@254"
],
"pulls": [
{
"repository": "novox/mesh-delivery",
"number": 254,
"head": "1eec825926d6b1fd826563945f57332fd99856c2",
"state": "merged",
"commit": "1eec825926d6b1fd826563945f57332fd99856c2",
"base": "main"
}
]
},
"entries": {
"mesh-delivery-indexer|src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9|": {
"key": "mesh-delivery-indexer|src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9|",
"module": "mesh-delivery-indexer",
"fingerprint": "src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"at": "2026-11-19T11:55:11.161173581Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_1027_7de55038/c6e6ffa6a785fa71", "sequence": 10198, "bytes": 871, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.1027", "heads": { "novox/mesh-delivery@254": "1eec825926d6b1fd826563945f57332fd99856c2" }, "opened": "2026-11-19T11:55:11.162465263Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-delivery@254" ], "pulls": [ { "repository": "novox/mesh-delivery", "number": 254, "head": "1eec825926d6b1fd826563945f57332fd99856c2", "state": "merged", "commit": "1eec825926d6b1fd826563945f57332fd99856c2", "base": "main" } ] }, "entries": { "mesh-delivery-indexer|src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9|": { "key": "mesh-delivery-indexer|src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9|", "module": "mesh-delivery-indexer", "fingerprint": "src2:7f96faf7403b252c378f09cfa1f4b3efa6efff490c1af295457a0c32e06426d9" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "at": "2026-11-19T11:55:11.161173581Z" } } } } ] } <!-- mesh-act:view.record/main_1027_7de55038/c6e6ffa6a785fa71.novox/mesh-delivery#254@1795089314183937781.8175336 -->
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#254