The seat-holder answer is read from the assigner's watched copy, so asking who holds a seat no longer takes 14 s (issue 1982) #256

Merged
mesh-tools merged 1 commits from fix/1982-seat-holders-from-watched-copy into main 2026-11-19 14:41:48 +00:00
Member

Issue 1982 (critical, the bus flood), fix 1, a small fix (hq playbook 08).

The verb mesh-module-assigner.assignments with seats listed the state seat-holders and made one bus get per key, about 14 s under today's load. The pipeline runner asks it six times per pipeline end, each cut at 5 s, so every widen spent 30 s. The tools process already keeps a watched copy of seat-holders (A-298, read by gate.Holders); the verb now answers from that copy and falls back to the listing only while the copy cannot be read. The answer's form is unchanged, so all 11 callers of mesh-sdk seatlist.HolderOf get the same answer, faster.

Quick or thorough: the quick fix (only the runner follows the seat-holders view) left eight other callers slow; the thorough fix (chosen) is one module and leaves the seat's contract as it is. The lead's answer and what exists today are issue 1982 note 2.

Tests: a subtest of TestTheSeatsVerbs proves the verb makes no store call while the watched copy answers and falls back when it cannot; it fails without the change. The module's unit suite and its integration level for the touched package pass; go vet with and without the integration tag is clean.

Reviewed-by: mesh-code-reviewer@g14 at 5bca54bb59
Pushed-by: fix-1982@g14

Issue 1982 (critical, the bus flood), fix 1, a small fix (hq playbook 08). The verb `mesh-module-assigner.assignments` with `seats` listed the state seat-holders and made one bus get per key, about 14 s under today's load. The pipeline runner asks it six times per pipeline end, each cut at 5 s, so every widen spent 30 s. The tools process already keeps a watched copy of seat-holders (A-298, read by gate.Holders); the verb now answers from that copy and falls back to the listing only while the copy cannot be read. The answer's form is unchanged, so all 11 callers of mesh-sdk seatlist.HolderOf get the same answer, faster. Quick or thorough: the quick fix (only the runner follows the seat-holders view) left eight other callers slow; the thorough fix (chosen) is one module and leaves the seat's contract as it is. The lead's answer and what exists today are issue 1982 note 2. Tests: a subtest of TestTheSeatsVerbs proves the verb makes no store call while the watched copy answers and falls back when it cannot; it fails without the change. The module's unit suite and its integration level for the touched package pass; go vet with and without the integration tag is clean. Reviewed-by: mesh-code-reviewer@g14 at 5bca54bb59b31f1df2f92ecc43106cf630461a04 Pushed-by: fix-1982@g14
mesh-tools added 1 commit 2026-11-19 13:35:02 +00:00
mesh-tools merged commit 6f8ba0bf69 into main 2026-11-19 14:41:48 +00:00
mesh-tools deleted branch fix/1982-seat-holders-from-watched-copy 2026-11-19 14:41:48 +00:00
Author
Member

{
"records": [
{
"instance": "record/main_1032_f5d6fc2d/9d7ef92d560e27cc",
"sequence": 10250,
"bytes": 873,
"of-bytes": 262144,
"waits": "its difference is not known yet",
"record": {
"milestone": "main.1032",
"heads": {
"novox/mesh-delivery@256": "6f8ba0bf69281f492267c356b1294963158034c5"
},
"opened": "2026-11-19T14:42:16.843386691Z",
"form": 1,
"group": {
"group": "",
"members": [
"novox/mesh-delivery@256"
],
"pulls": [
{
"repository": "novox/mesh-delivery",
"number": 256,
"head": "6f8ba0bf69281f492267c356b1294963158034c5",
"state": "merged",
"commit": "6f8ba0bf69281f492267c356b1294963158034c5",
"base": "main"
}
]
},
"entries": {
"mesh-delivery-assigner|src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add|": {
"key": "mesh-delivery-assigner|src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add|",
"module": "mesh-delivery-assigner",
"fingerprint": "src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add"
}
},
"outcomes": {
"|||take-in": {
"key": "|||take-in",
"module": "",
"step": "take-in",
"outcome": "taken-in",
"at": "2026-11-19T14:42:16.84253236Z"
}
}
}
}
]
}

<!-- mesh-delivery:view --> { "records": [ { "instance": "record/main_1032_f5d6fc2d/9d7ef92d560e27cc", "sequence": 10250, "bytes": 873, "of-bytes": 262144, "waits": "its difference is not known yet", "record": { "milestone": "main.1032", "heads": { "novox/mesh-delivery@256": "6f8ba0bf69281f492267c356b1294963158034c5" }, "opened": "2026-11-19T14:42:16.843386691Z", "form": 1, "group": { "group": "", "members": [ "novox/mesh-delivery@256" ], "pulls": [ { "repository": "novox/mesh-delivery", "number": 256, "head": "6f8ba0bf69281f492267c356b1294963158034c5", "state": "merged", "commit": "6f8ba0bf69281f492267c356b1294963158034c5", "base": "main" } ] }, "entries": { "mesh-delivery-assigner|src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add|": { "key": "mesh-delivery-assigner|src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add|", "module": "mesh-delivery-assigner", "fingerprint": "src2:e6e9b3069bc240e01daba0689ca1ad8212be137784c9ee7468d241e544da3add" } }, "outcomes": { "|||take-in": { "key": "|||take-in", "module": "", "step": "take-in", "outcome": "taken-in", "at": "2026-11-19T14:42:16.84253236Z" } } } } ] } <!-- mesh-act:view.record/main_1032_f5d6fc2d/9d7ef92d560e27cc.novox/mesh-delivery#256@1795099340900701428.a18a5e64 -->
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-delivery#256