Builds the design lines of hq design/47-H1-answers-59: H-A-484 (9feaea71) with its addendum, and H-A-485 (4ffe1fd8), design 47 H2.
Causes
Reservations never dropped (H-A-484). The older forge module refused nested package tags (a package path under the catalog's trunk). A version-released whose tag was refused was handed back at once, spent its five deliveries in seconds and was dropped by the bus: its reservation stood and its publish item asked again every 30 s for ever.
An again pipeline's tiers never wanted (H-A-485). The assigner took a tier progress for pipeline.<branch>.<revision> only, so a pipeline started again at the head (<branch>.<revision>.again.<n>) left an empty tier record, read as an empty end: its later tiers were never wanted.
Change
Builder: at the start it holds every built, unreleased reservation against the catalog's verb versions and takes a released one in as its version-released would (tag, release, bound and item ended, findings cleared). A refused tag is handed back with the publish pause instead of at once. The tag check itself stays the forge module's, which already accepts a nested package path.
One parse of the pipeline key forms: a new mesh-delivery-sdk/pipelinekey package, over the contract's key parsers, reads a pipeline's key for the assigner's tier progress and the runner's mover keys. A pipeline-ended whose key is of no form is refused loudly and nothing of it is kept.
Tests
mesh-delivery-builder/reserve_test.go: the start take-in of a released reservation, the refused tag handed back with the pause.
mesh-delivery-assigner/tiers_test.go, pipelines_test.go: tier progress moved for an again key; a key of no form refused.
mesh-delivery-sdk/pipelinekey/pipelinekey_test.go: every key form, plain and again.
internal/pipeline/verbs_test.go: the runner's mover keys for an again pipeline.
Reviewed-by: mesh-code-reviewer@shanks at a5495bb15e
Pushed-by: lead-47@shanks
Builds the design lines of hq design/47-H1-answers-59: H-A-484 (9feaea71) with its addendum, and H-A-485 (4ffe1fd8), design 47 H2.
## Causes
- **Reservations never dropped (H-A-484).** The older forge module refused nested package tags (a package path under the catalog's trunk). A version-released whose tag was refused was handed back at once, spent its five deliveries in seconds and was dropped by the bus: its reservation stood and its publish item asked again every 30 s for ever.
- **An again pipeline's tiers never wanted (H-A-485).** The assigner took a tier progress for `pipeline.<branch>.<revision>` only, so a pipeline started again at the head (`<branch>.<revision>.again.<n>`) left an empty tier record, read as an empty end: its later tiers were never wanted.
## Change
- **Builder:** at the start it holds every built, unreleased reservation against the catalog's verb versions and takes a released one in as its version-released would (tag, release, bound and item ended, findings cleared). A refused tag is handed back with the publish pause instead of at once. The tag check itself stays the forge module's, which already accepts a nested package path.
- **One parse of the pipeline key forms:** a new `mesh-delivery-sdk/pipelinekey` package, over the contract's key parsers, reads a pipeline's key for the assigner's tier progress and the runner's mover keys. A pipeline-ended whose key is of no form is refused loudly and nothing of it is kept.
## Tests
- `mesh-delivery-builder/reserve_test.go`: the start take-in of a released reservation, the refused tag handed back with the pause.
- `mesh-delivery-assigner/tiers_test.go`, `pipelines_test.go`: tier progress moved for an again key; a key of no form refused.
- `mesh-delivery-sdk/pipelinekey/pipelinekey_test.go`: every key form, plain and again.
- `internal/pipeline/verbs_test.go`: the runner's mover keys for an again pipeline.
Reviewed-by: mesh-code-reviewer@shanks at a5495bb15e27b19f06190b82b1b16e98e96c0b91
Pushed-by: lead-47@shanks
A version-released whose tag the seat git's holder refused was handed back at once,
spent its five deliveries in seconds and was dropped by the bus: its reservation stood
and its publish item asked again every 30 s for ever. At the start the builder now holds
every built, unreleased reservation against the catalog's verb versions and takes a
released one in as its version-released would (tag, release, bound and item ended,
findings cleared); a refused tag is handed back with the publish pause. The tag check
itself is the forge module's, already accepting a nested package path on the catalog's
trunk.
Builds: design 47 H2 H-A-484, H-A-484 addendum
The assigner took a tier progress for `pipeline.<branch>.<revision>` only (two dots), so
the progress of a pipeline started again at the head, `<branch>.<revision>.again.<n>`,
was never moved and read as an empty end: its later tiers were never wanted. One parse
of the runner's seat's key forms (mesh-delivery-sdk pipelinekey, over the contract's key
parsers) now reads a pipeline's key for the assigner's tier progress and the runner's
mover keys; a pipeline-ended whose key is of no form is refused loudly and nothing of
it is kept.
Builds: design 47 H2 H-A-485
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Builds the design lines of hq design/47-H1-answers-59: H-A-484 (9feaea71) with its addendum, and H-A-485 (4ffe1fd8), design 47 H2.
Causes
pipeline.<branch>.<revision>only, so a pipeline started again at the head (<branch>.<revision>.again.<n>) left an empty tier record, read as an empty end: its later tiers were never wanted.Change
mesh-delivery-sdk/pipelinekeypackage, over the contract's key parsers, reads a pipeline's key for the assigner's tier progress and the runner's mover keys. A pipeline-ended whose key is of no form is refused loudly and nothing of it is kept.Tests
mesh-delivery-builder/reserve_test.go: the start take-in of a released reservation, the refused tag handed back with the pause.mesh-delivery-assigner/tiers_test.go,pipelines_test.go: tier progress moved for an again key; a key of no form refused.mesh-delivery-sdk/pipelinekey/pipelinekey_test.go: every key form, plain and again.internal/pipeline/verbs_test.go: the runner's mover keys for an again pipeline.Reviewed-by: mesh-code-reviewer@shanks at
a5495bb15ePushed-by: lead-47@shanks