mesh-delivery-checker: a failure's words are never "PASS"; with no cause, take the runtime's line or say so (issue 1901) #43

2026-10-25T14:59:37Z

mesh-tools commented

2026-10-25 14:59:37 +00:00

Issue 1901, met a third time: a mesh-controller try reported its only failure as "...cmd/mesh-controller: PASS" (a race reported after PASS, exit 66).

The checker's half, for a build module that sends no cause (the one on main today):

go's exact summary lines are dropped from a failure's words.
With no cause sent, the cause is the first column-0 race heading, panic, fatal error or signal line, read before the words are cut. A test's logged "panic:" is never taken.
When nothing is left (a timeout, exit or kill that arrives as "FAIL\t\t" alone), the words say "the package failed with no test to name and no panic, signal or build error in its output (an older build module sent no cause)", never empty.
The words keep MaxWords (4096 bytes) exactly.

Tests (1901/AC5), from real go test -json captures, each written first and seen to fail: among them TestAPackageStoppedWithOnlyItsFailLineIsStillWorded; TestTheWordsKeepTheirBoundExactly guards the bound.

Checked: gofmt, go vet with and without -tags integration, the unit suite. A try passed on 6d2d50b1 (try-1792939129239883683). The operator decided no checks run during the recovery (2026-10-25 15:53, issue 1945 note 27). Works with the old and new build module either way; the build module's half is mesh-catalog fix/1901-package-cause.

Reviewed-by: reviewer-1901b@shanks at dd9138310c

Issue 1901, met a third time: a mesh-controller try reported its only failure as "...cmd/mesh-controller: PASS" (a race reported after PASS, exit 66). The checker's half, for a build module that sends no cause (the one on main today): - go's exact summary lines are dropped from a failure's words. - With no cause sent, the cause is the first column-0 race heading, panic, fatal error or signal line, read before the words are cut. A test's logged "panic:" is never taken. - When nothing is left (a timeout, exit or kill that arrives as "FAIL\t<pkg>\t<time>" alone), the words say "the package failed with no test to name and no panic, signal or build error in its output (an older build module sent no cause)", never empty. - The words keep MaxWords (4096 bytes) exactly. Tests (1901/AC5), from real go test -json captures, each written first and seen to fail: among them TestAPackageStoppedWithOnlyItsFailLineIsStillWorded; TestTheWordsKeepTheirBoundExactly guards the bound. Checked: gofmt, go vet with and without -tags integration, the unit suite. A try passed on 6d2d50b1 (try-1792939129239883683). The operator decided no checks run during the recovery (2026-10-25 15:53, issue 1945 note 27). Works with the old and new build module either way; the build module's half is mesh-catalog fix/1901-package-cause. Reviewed-by: reviewer-1901b@shanks at dd9138310c48afd8d3524f1c9b0849877d450160

mesh-tools added 3 commits 2026-10-25 14:59:37 +00:00

mesh-delivery-checker: a failure's words are never "PASS"; with no cause, take the panic line (issue 1901) 6d2d50b1e1

A try of mesh-controller's status read 'cmd/mesh-controller: PASS': the build
module sent a package failure whose output began with go test's PASS. The
checker now drops go test's summary lines, takes the first panic, fatal error
or signal line as the cause when the build module told none apart (read before
the words are cut), says the tests passed and the program failed after them
when nothing else is left, and cuts a cause to 1 KB so the words keep their
bound (1901/AC5).

mesh-delivery-checker: with no cause told apart, a race report is the cause (issue 1901) f72f57f6e2

An older build module's output for a race after the tests' PASS is now worded
by the race's heading, access and frame, not by go test's PASS or the report's
separator line (1901/AC5).

mesh-delivery-checker: a package sent as its FAIL line alone is still worded, and the words keep their bound exactly (issue 1901, review round 1)

mesh/check pass dd9138310c48 on 51444a834173 | unit 2015 run, 2883 kept, 5 skipped | integration 2037 run, 2978 kept, 9 skipped | over bound: unit, in…

mesh/delivery-group group fix/1901-package-cause held: a member is held: novox/mesh-catalog@155124b59af4 (merged without a passing check: only a person decides…

Details

mesh/delivery held for a person: merged without a passing check: only a person decides what follows

Details

dd9138310c

The build module on main sends a timeout, exit or kill as only 'FAIL <pkg>':
dropping summary lines left empty words. They now say the package failed with
no cause sent. Causes match at column 0 only, summary lines only in go's exact
forms, and the words count the cause, the marker and the newlines within
MaxWords.

mesh-tools commented

2026-10-25 14:59:40 +00:00

Delivery novox/mesh-delivery@dd9138310c48 — held since 2026-10-25T15:07:59Z

Held for a person: merged without a passing check: only a person decides what follows — the merge reached the trunk without a passing check.

Source — source.main moved to novox/mesh-delivery@51444a8341. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1901-package-cause: novox/mesh-catalog@155124b59a, novox/mesh-delivery@dd9138310c

Transitions

2026-10-25 14:59 (new) → proposed (announced): novox/mesh-delivery#43's head announced
2026-10-25 15:07 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides what follows

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-delivery@dd9138310c48` — **held** since 2026-10-25T15:07:59Z Held for a person: merged without a passing check: only a person decides what follows — the merge reached the trunk without a passing check. **Source** — source.main moved to novox/mesh-delivery@51444a834173. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1901-package-cause`: novox/mesh-catalog@155124b59af4, novox/mesh-delivery@dd9138310c48 **Transitions** - 2026-10-25 14:59 (new) → proposed (announced): novox/mesh-delivery#43's head announced - 2026-10-25 15:07 proposed → held (merged-unchecked): merged without a passing check — a verdict known with it is taken first: only a person decides what follows The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

jschoubben merged commit 51444a8341 into main

2026-10-25 15:07:47 +00:00

jschoubben deleted branch fix/1901-package-cause

2026-10-25 15:07:48 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#43