Every delivery part opens its bus connection through mesh-sdk's module helpers (issue 1242) #87

Merged

mesh-tools merged 1 commits from fix/1242-bus-helper into main 2026-10-27 19:49:23 +00:00

Conversation 1 Commits 1 Files Changed 36

+133 -699

mesh-tools commented 2026-10-27 19:46:35 +00:00

Member

Copy Link

Copy Source

Issue 1242. assigner, builder, checker, forge-bridge, indexer, teller, view and watchman use process.ReadBrokerAccount and cred.Dial, bind with cred.EventConsumer and hear with process.HearEvents; own-stream and event subjects come from the sdk. Behaviour is identical (connection name, inbox prefix, pin, reconnects, durable names, subjects), as the review compared part by part. Net +133/-699 over 36 files. A guard test (TestNoPartHandWritesItsBusConnection, mesh-delivery-teller) refuses a hand-written connection. Pins mesh-sdk 8ad9372b exactly (delivery group fix/1242-bus-helper); the pin jump brings the watchman and the assigner up to the sdk main the other parts already run (Self wants, waiting-yes haves; the assigner's candidate fold of 05b6783).

Left out: mesh-grants (another fix in flight there, issue 1945).

Reviewed-by: review-1242@shanks at 96be0c3377

Issue 1242. assigner, builder, checker, forge-bridge, indexer, teller, view and watchman use process.ReadBrokerAccount and cred.Dial, bind with cred.EventConsumer and hear with process.HearEvents; own-stream and event subjects come from the sdk. Behaviour is identical (connection name, inbox prefix, pin, reconnects, durable names, subjects), as the review compared part by part. Net +133/-699 over 36 files. A guard test (TestNoPartHandWritesItsBusConnection, mesh-delivery-teller) refuses a hand-written connection. Pins mesh-sdk 8ad9372b exactly (delivery group fix/1242-bus-helper); the pin jump brings the watchman and the assigner up to the sdk main the other parts already run (Self wants, waiting-yes haves; the assigner's candidate fold of 05b6783). Left out: mesh-grants (another fix in flight there, issue 1945). Reviewed-by: review-1242@shanks at 96be0c3377c46aacbff6183ae3e3455968359693

mesh-tools added 1 commit 2026-10-27 19:46:35 +00:00

Move every delivery part's bus connection onto mesh-sdk's module helpers: credential, pinned dial, own-stream subjects, durable consumer, and refuse a hand-written one (issue 1242) 96be0c3377

mesh-tools commented 2026-10-27 19:46:40 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-delivery@96be0c3377c4 — merged since 2026-10-27T19:49:25Z

Source — source.main moved to novox/mesh-delivery@24cb379434. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1242-bus-helper: novox/mesh-delivery@96be0c3377, novox/mesh-sdk@8ad9372b19

Transitions

• 2026-10-27 19:46 (new) → proposed (announced): novox/mesh-delivery#87's head announced
• 2026-10-27 19:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-10-27 19:49 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-delivery@96be0c3377c4` — **merged** since 2026-10-27T19:49:25Z **Source** — source.main moved to novox/mesh-delivery@24cb379434f5. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1242-bus-helper`: novox/mesh-delivery@96be0c3377c4, novox/mesh-sdk@8ad9372b1952 **Transitions** - 2026-10-27 19:46 (new) → proposed (announced): novox/mesh-delivery#87's head announced - 2026-10-27 19:46 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 19:49 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 24cb379434 into main 2026-10-27 19:49:23 +00:00

mesh-tools deleted branch fix/1242-bus-helper 2026-10-27 19:49:23 +00:00

mesh-tools referenced this pull request 2026-10-27 20:31:42 +00:00

mesh-grants and the assigner: grant every node the served keys it composes with (issue 1126, group fix/1126-node-creds) #89

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-delivery#87