From 22f3658a36a63096e542a8b746cb6b003d7dd977 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 2 Nov 2026 22:22:23 +0100 Subject: [PATCH] Leave compose-candidate out of the checker's invokes until the new indexer runs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The running indexer, built before the verb existed, refuses a manifest invoking it, and one refused manifest holds the grants part's whole list: no new grant is written, so the new indexer never moves (issue 1126, 2026-11-02). Quick fix, chosen because the thorough one (the grants part keeps only the refused module's grants) cannot be delivered while the list is held; a follow-up adds the invoke back. Until then a check's compose-candidate call is refused on the bus and the node is named silent: the check passes with that warning (engines.go, ADR 0593 §9). Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL --- modules/mesh-delivery-checker/manifest_test.go | 12 +++++++----- modules/mesh-delivery-checker/module.json | 3 +-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/modules/mesh-delivery-checker/manifest_test.go b/modules/mesh-delivery-checker/manifest_test.go index 7d995a3..691686b 100644 --- a/modules/mesh-delivery-checker/manifest_test.go +++ b/modules/mesh-delivery-checker/manifest_test.go @@ -111,11 +111,13 @@ func TestManifestDeclarations(t *testing.T) { // 1678/AC1 } // 1887/A5b: the checker reads nothing of the controller's plans-building (ADR 0483 superseded by ADR 0525 §7), calls no // build module's tool and holds no capacity: it puts check asks on the Go and Node build seats (ADR 0525 §1, §4). - // The forge's reads for a mesh-sdk pin (ADR 0484 clause 9), and of the node seat node-engine its one verb - // compose-candidate, asked of every placed node (ADR 0593 §7), never the seat's other verbs. - if want := []string{"gitea.gitea_commits", "gitea.gitea_compare", "gitea.gitea_get_file", "gitea.gitea_list_branches", - "seat:node-engine.compose-candidate"}; !reflect.DeepEqual(sorted(m.Invokes), want) { - t.Errorf("invokes = %v, want the forge's reads and compose-candidate", m.Invokes) + // The forge's reads for a mesh-sdk pin (ADR 0484 clause 9). Not yet the node seat node-engine's compose-candidate + // (ADR 0593 §7): the indexer that runs while this delivers was built before the verb existed and refuses a manifest + // invoking it, which held the grants part's whole list (issue 1126, 2026-11-02); a follow-up adds it back once the + // new indexer runs. + if want := []string{"gitea.gitea_commits", "gitea.gitea_compare", "gitea.gitea_get_file", + "gitea.gitea_list_branches"}; !reflect.DeepEqual(sorted(m.Invokes), want) { + t.Errorf("invokes = %v, want the forge's reads", m.Invokes) } if want := []string{"node-build-go", "node-build-node"}; !reflect.DeepEqual(sorted(m.Uses), want) { t.Errorf("uses = %v, want the Go and Node build seats", m.Uses) diff --git a/modules/mesh-delivery-checker/module.json b/modules/mesh-delivery-checker/module.json index 767884c..1b3b00f 100644 --- a/modules/mesh-delivery-checker/module.json +++ b/modules/mesh-delivery-checker/module.json @@ -65,8 +65,7 @@ "gitea.gitea_commits", "gitea.gitea_compare", "gitea.gitea_get_file", - "gitea.gitea_list_branches", - "seat:node-engine.compose-candidate" + "gitea.gitea_list_branches" ], "own-secrets": { -- 2.54.0