From 6d6caf20e164042a7a7893df6735292ea471f632 Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 19 Nov 2026 12:50:53 +0100 Subject: [PATCH] takein: the test's pending revision names a lost merge, since A-476 (b) no longer counts a build it waits for TestTakeInEvents failed on main since A-476 (b) dropped WaitsFor as a reason a pending revision holds; its sample and one refusal case still named only that. Seen in main.1025.mesh-delivery-indexer, unit and integration. Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy --- modules/mesh-delivery-indexer/takein/takein_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/mesh-delivery-indexer/takein/takein_test.go b/modules/mesh-delivery-indexer/takein/takein_test.go index a2376fe6..67029fd2 100644 --- a/modules/mesh-delivery-indexer/takein/takein_test.go +++ b/modules/mesh-delivery-indexer/takein/takein_test.go @@ -16,7 +16,7 @@ import ( func sampleTakeIns(since time.Time) []TakeIn { m := []Merge{{Repository: "novox/mesh-delivery", Number: 9, Merge: "eeee"}} return []TakeIn{ - {Kind: TakeInPending, Key: PendingKey(12), What: TakeInRevision, Merges: m, WaitsFor: "src2:abc", Since: since}, + {Kind: TakeInPending, Key: PendingKey(12), What: TakeInRevision, Merges: m, Lost: []string{"m.00000000000000000011"}, Since: since}, {Kind: TakeInPending, Key: GroupTakeInKey("feat/take-in"), What: TakeInGroup, Merges: m, Group: "feat/take-in", Members: []meshdeliveryclient.Head{{Repository: "novox/mesh-delivery", Number: 9, Head: "ffff"}, {Repository: "novox/mesh-sdk", Number: 37, Head: "dddd"}}, Since: since}, {Kind: TakeInTaken, Key: PendingKey(12), What: TakeInRevision, Merges: m, WaitsFor: "src2:abc", Since: since, @@ -70,7 +70,7 @@ func TestTakeInEvents(t *testing.T) { }{ {"group take-in without its group", "names its group", 1, func(t *TakeIn) { t.Group = "" }}, {"group take-in under another group's key", "g.other", 1, func(t *TakeIn) { t.Key = GroupTakeInKey("other") }}, - {"pending revision waiting for no build", "lost", 0, func(t *TakeIn) { t.WaitsFor = "" }}, + {"pending revision naming neither a lost merge nor a refusal", "lost", 0, func(t *TakeIn) { t.Lost = nil }}, {"pending with a hand act", "only a taken event", 0, func(t *TakeIn) { t.By = "someone@node" }}, {"hand act without its by", "by", 2, func(t *TakeIn) { t.By = "" }}, {"take-in without merges", "no merge", 0, func(t *TakeIn) { t.Merges = nil }}, -- 2.54.0