TestIndexerCountsOnlyThePlacedBuildNodesToolchains failed on the build node under load
(pipeline main.18) in two ways, both of the test, not of the indexer's count of the
placed build nodes' toolchains:
- it restarted the indexer as soon as the module was written, before its take-in
ended: the stop cancelled the take-in, its source-moved stayed unacknowledged, and
the branch's durable (one message at a time) held the next one behind it for its
acknowledgement wait, past the test's 20 s bound. Each restart now waits for the
source-moved's acknowledgement; TestIndexerWhole's restart the same way.
- a source-moved said right after a restart could reach the stopped program's pull,
still counted until the bus closed its connection. restart now returns only once
the bus has closed every connection of the stopped program, heard on the system
account's disconnect events, with no sleep.
Under load (8 runs side by side, GOMAXPROCS=1) the test failed 5 of 80 runs before,
2 of 240 with the first change alone, and 0 of 600 with both; TestIndexerWhole 0 of 600.
No test added.
Builds: design 47 H §743