The running checker records the manifest validator's cases, each fetch's programs and the engines' answers as facts, and the rules package judges them, with the notes it gives a reader, so the checking program judges every rule the running checker judged. The module graph's cycle stays with the asking: its facts are whole manifests, over a run's input bound; G's program reads them from the heads. Claude-Session: https://claude.ai/code/session_01NcbgfFSnn24M3GcqttoU7i
34 lines
1.7 KiB
Go
34 lines
1.7 KiB
Go
package check
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"mesh-delivery-checker/rules"
|
|
)
|
|
|
|
// A change that adds or modifies a compiled program fails (issue 1577): it is build output, `go build` in a module's folder
|
|
// writes one beside go.mod, and `git add -A` takes it. The build module's fetch step, which holds the merged clone, reads the
|
|
// first bytes of each changed file and reports the programs (mesh-sdk buildstep.MergeInto); the checker judges the answer.
|
|
|
|
// NoProgramsReported is the warning of a build module whose fetch answered no programs field: an older module, which cannot
|
|
// tell, so the check does not refuse a program it did not look for.
|
|
const NoProgramsReported = "the build module did not report programs: a compiled program in the change is not refused"
|
|
|
|
// checkBinariesOf records what a pull request's first fetch answer read of compiled programs, whichever build module
|
|
// gave it, as a fact the rules judge (rules.JudgePrograms); a build module that reports no programs leaves a warning on
|
|
// the check and passes it.
|
|
func (st *state) checkBinariesOf(t *target) {
|
|
key := fmt.Sprintf("%s#%d", t.pull.Repository, t.pull.Number)
|
|
if t.fetched.Merge == "" {
|
|
return // no merge was made: nothing was changed to judge
|
|
}
|
|
if t.fetched.Programs == nil {
|
|
st.c.note(fmt.Sprintf("%s: %s (%s)", key, NoProgramsReported, t.module))
|
|
st.c.warn(key, fmt.Sprintf("a compiled program is not refused: %s reported no programs", t.module))
|
|
st.j.logf("%s: %s (%s)", key, NoProgramsReported, t.module)
|
|
return
|
|
}
|
|
st.facts = append(st.facts, rules.Step{Repository: t.pull.Repository, Number: t.pull.Number, Module: t.module, Node: t.node,
|
|
Programs: &rules.Programs{Key: key, Files: t.fetched.Programs}})
|
|
}
|