jschoubben 2d8ad2e66a Checker: no candidate is left without a verdict (issue 1733) ...

Once the gate's one-hour ask bound goes (mesh-catalog fix/1733-no-hour), the
gate asks the operator's Approve only on a verdict, so every path that left
a candidate without one now writes one, from an event and with no timer:
- a group with a member whose repository's trunk head is not known (a pull
  request the checker cannot claim) is not judged in part: its verdict fails
  naming that repository, and every status of the group says so (a pass of
  the others would have let it merge with that member never checked);
- the verdict of heads that cannot be judged replaces whatever the key held,
  such as a running verdict left by a check that can no longer run;
- a verdict key deleted is judged again on its delete (the checker watches its
  verdicts), and a check running when its key is deleted writes it anew.

Tests: three rows at the end of the no-trunk test; counts unchanged.

2026-10-28 21:50:03 +01:00

..

testdata/captured

The captured clean fetches carry the programs a current build module answers, so lines asserted whole do not warn (issue 1577)

2026-10-26 19:16:25 +01:00

adr548_test.go

checker: a check is never held by a turn its own heads wait in, the node-engine read at its running commit is named and carried when it moves, and a gate bucket made after the start is opened before the next claim (ADR 0548 §3, §6; issue 568, review round 1)

2026-10-26 12:14:50 +01:00

askagain.go

Checker: delete a check's asks key at its end, so the state asks holds only the checks that run

2026-10-28 20:39:50 +01:00

awaiting_test.go

Take a later composition into a verdict that failed only because placed nodes had not answered, so a sleeping node's answer passes the check on its event with no new check (issue 1126, ADR 0559 §5)

2026-10-27 02:29:20 +01:00

awaiting.go

Take a later composition into a verdict that failed only because placed nodes had not answered, so a sleeping node's answer passes the check on its event with no new check (issue 1126, ADR 0559 §5)

2026-10-27 02:29:20 +01:00

beside.go

checker: a check is never held by a turn its own heads wait in, the node-engine read at its running commit is named and carried when it moves, and a gate bucket made after the start is opened before the next claim (ADR 0548 §3, §6; issue 568, review round 1)

2026-10-26 12:14:50 +01:00

binaries_test.go

Checker refuses a program a commit of the branch added and a later one removed: it stays in history (issue 1577)

2026-10-26 19:47:53 +01:00

binaries.go

Checker refuses a program a commit of the branch added and a later one removed: it stays in history (issue 1577)

2026-10-26 19:47:53 +01:00

bounded.go

Builder and checker read tools read only the keys they need, in parallel, at most 1000 a call (issue 1827)

2026-10-26 00:39:08 +01:00

builds.go

The checker's line says whether each candidate module's build is built, failed or waiting, read from the builder's keys (issue 1684)

2026-10-21 21:29:13 +02:00

case.go

Checker: say loudly that a pull request cannot be judged when its repository has no trunk head (issue 1422)

2026-10-28 11:03:39 +01:00

checker_test.go

Checker: no candidate is left without a verdict (issue 1733)

2026-10-28 21:50:03 +01:00

checker.go

Checker: no candidate is left without a verdict (issue 1733)

2026-10-28 21:50:03 +01:00

composition_test.go

checker: a carry keeps the composition it passed while no composed fingerprint changed, and composes again otherwise (ADR 0548 §5; issue 568 D3)

2026-10-26 11:32:31 +01:00

digestform_test.go

Read a level's digest from mesh-sdk's list form, so kept verdicts hold for a check whose end names a package like token (issue 1930)

2026-10-23 23:37:49 +02:00

doc.go

Keep a passing package's verdict once under its digest, so a second check can take it (issue 1287)

2026-10-21 21:02:54 +02:00

every_failure_test.go

Name every failed test in a check's verdict and a try's failed list (issue 1921)

2026-10-26 10:58:13 +01:00

examiner_test.go

Checker: put every node's name on each check ask for the names check, so no repository lists them (ADR 0567 §12, issue 1126)

2026-10-28 18:34:02 +01:00

failure_words_test.go

The checker pins the SDK of review round 1, and its hid-the-failure cases join the older build module's test (issue 1901)

2026-10-26 20:19:07 +01:00

fakes_test.go

Checker: delete a check's asks key at its end, so the state asks holds only the checks that run

2026-10-28 20:39:50 +01:00

gate_test.go

checker: a trunk move never ends a check; once it ended, its pass is carried and names the commits it was carried from, and a failed carry names the move (ADR 0548 §1, §5; issue 568 D2)

2026-10-26 11:30:46 +01:00

heard_test.go

Judge each pull request's check as one ask on the build seats' check stream, a re-judge on recheck, so the checker chooses no node and a lost node's check is redelivered, not moved (issue 1887 A5a, ADR 0525 §1, §3, ADR 0536 §4)

2026-10-23 16:05:55 +02:00

heard.go

Judge each pull request's check as one ask on the build seats' check stream, a re-judge on recheck, so the checker chooses no node and a lost node's check is redelivered, not moved (issue 1887 A5a, ADR 0525 §1, §3, ADR 0536 §4)

2026-10-23 16:05:55 +02:00

judge.go

Checker: put every node's name on each check ask for the names check, so no repository lists them (ADR 0567 §12, issue 1126)

2026-10-28 18:34:02 +01:00

judged_test.go

Place the change's own repository beside it at its trunk, so a shrink-only list test compares with the trunk's copy at $MESH_CHECK_BESIDE/<name> (issue 1887 A12, ADR 0529 §2)

2026-10-23 15:35:37 +02:00

kept_test.go

Checker: a package with skipped tests is withheld from the kept verdicts, not the whole result (issue 890)

2026-10-26 12:29:14 +01:00

kept.go

Checker: a package with skipped tests is withheld from the kept verdicts, not the whole result (issue 890)

2026-10-26 12:29:14 +01:00

line_test.go

Say the unit level's gofmt and go vet time in the check's line, and pin the group's mesh-sdk head that carries it (issue 1887 D7-go, review round 2 item 5)

2026-10-23 16:51:55 +02:00

line.go

A check judged by a build module that reports no programs says so in its status line, still passing: the refusal did not run (issue 1577)

2026-10-26 19:08:00 +01:00

lostask_test.go

Checker: delete a check's asks key at its end, so the state asks holds only the checks that run

2026-10-28 20:39:50 +01:00

lostask.go

Checker: never lose a step's end, and ask a lost check again (issue 734's kind)

2026-10-28 20:27:41 +01:00

package_cause_test.go

The checker pins the SDK of review round 1, and its hid-the-failure cases join the older build module's test (issue 1901)

2026-10-26 20:19:07 +01:00

pins_test.go

checker: a check is never held by a turn its own heads wait in, the node-engine read at its running commit is named and carried when it moves, and a gate bucket made after the start is opened before the next claim (ADR 0548 §3, §6; issue 568, review round 1)

2026-10-26 12:14:50 +01:00

pins.go

A try of a branch accepts a mesh-sdk pin at the head of mesh-sdk's branch of the same name, so a milestone's repositories can be tried before their pull requests (issue 1921)

2026-10-24 16:41:39 +02:00

preview_named_test.go

Carry each named path's object from a fetch's module trees into the merge preview, so the indexer narrows a candidate's tree as the merge's (issue 1758, I8, ADR 0499 §2)

2026-10-22 18:15:09 +02:00

preview.go

Carry each named path's object from a fetch's module trees into the merge preview, so the indexer narrows a candidate's tree as the merge's (issue 1758, I8, ADR 0499 §2)

2026-10-22 18:15:09 +02:00

rank_test.go

checker_status reads the node-engine at its running commit, as the checker's decision does, so it stops listing every candidate as waiting for a trunk move (issue 568)

2026-10-26 13:25:18 +01:00

read_test.go

Checker: no candidate is left without a verdict (issue 1733)

2026-10-28 21:50:03 +01:00

read.go

Checker: no candidate is left without a verdict (issue 1733)

2026-10-28 21:50:03 +01:00

results.go

Merge main into fix/1901-failure-contract: the checker pins mesh-sdk a2759ec, the group's sdk head (issue 1901)

2026-10-27 00:39:35 +01:00

store.go

Keep a passing package's verdict once under its digest, so a second check can take it (issue 1287)

2026-10-21 21:02:54 +02:00

try_test.go

Say the try limits as what they are: a check when a try is asked

2026-10-26 20:11:08 +01:00

try.go

Say the try limits as what they are: a check when a try is asked

2026-10-26 20:11:08 +01:00

turns.go

checker: claim no check of a repository an approved merge holds a turn on, and claim it when the turn goes (ADR 0548 §3; issue 568 D1)

2026-10-26 11:29:25 +01:00