From 7618f661ea80e3706ed0ce7552e9c8789d907e31 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 03:43:49 +0200 Subject: [PATCH 1/3] Fail, not skip, when the checker places no controller beside the node-engine (issue 1295) --- internal/bootstrap/genesis_form_test.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/internal/bootstrap/genesis_form_test.go b/internal/bootstrap/genesis_form_test.go index 3aceee0..dda3852 100644 --- a/internal/bootstrap/genesis_form_test.go +++ b/internal/bootstrap/genesis_form_test.go @@ -242,16 +242,14 @@ func TestAFileNothingOfTheControllerWritesIsStillRefused(t *testing.T) { // node-engine's check has the controller cloned beside it (MESH_CHECK_BESIDE), where it must be; else a // checkout beside this one; else it skips aloud. // -// **The checker running today places no controller beside this repository** (issue 1295, R4g): its rules put only the -// catalogue and mesh-sdk beside mesh-host, and until R4g deleted this repository's merge-check.sh nothing here was judged -// by it. A MESH_CHECK_BESIDE without a mesh-controller directory therefore skips aloud; mesh-delivery #27 places the -// controller from R4g's delivery on, and this is a failure again then. A directory without its module.json still fails. +// The checker places the controller beside this repository (mesh-delivery's besideRules, since R4g, issue 1295), so a +// MESH_CHECK_BESIDE without a mesh-controller directory, or without its module.json, fails. Only a run with no +// MESH_CHECK_BESIDE and no checkout beside this one (a developer's clone alone) skips aloud. func TestTheControllersOwnManifestPassesStepNine(t *testing.T) { var manifest []byte if root := os.Getenv("MESH_CHECK_BESIDE"); root != "" { if info, err := os.Stat(filepath.Join(root, "mesh-controller")); err != nil || !info.IsDir() { - t.Skip("NOT JUDGED: the checker running today places no mesh-controller beside mesh-host's check; " + - "mesh-delivery #27 places it from R4g's delivery on, and this is a failure again then (issue 1295)") + t.Fatalf("the controller is not beside this check in MESH_CHECK_BESIDE=%s: the checker places mesh-controller beside the node-engine's check (mesh-delivery besideRules, issue 1295), and this test judges the controller's own manifest", root) } raw, err := os.ReadFile(filepath.Join(root, "mesh-controller", "module.json")) if err != nil { From b4f6537f802ef7ba40c9238bd7573fec366d413c Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 04:01:02 +0200 Subject: [PATCH 2/3] Mark the packages whose tests read files outside their directory, so mesh-build-go never keeps their verdict (issue 1935) --- internal/bootstrap/reads-outside | 1 + packaging/reads-outside | 1 + 2 files changed, 2 insertions(+) create mode 100644 internal/bootstrap/reads-outside create mode 100644 packaging/reads-outside diff --git a/internal/bootstrap/reads-outside b/internal/bootstrap/reads-outside new file mode 100644 index 0000000..976b0f5 --- /dev/null +++ b/internal/bootstrap/reads-outside @@ -0,0 +1 @@ +These tests read files outside this directory (the repository's root files or other directories): mesh-build-go never keeps this package's verdict (issue 1935). diff --git a/packaging/reads-outside b/packaging/reads-outside new file mode 100644 index 0000000..976b0f5 --- /dev/null +++ b/packaging/reads-outside @@ -0,0 +1 @@ +These tests read files outside this directory (the repository's root files or other directories): mesh-build-go never keeps this package's verdict (issue 1935). From 13bdcb694be02ee792a2daa48545b09d3452c0e8 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 24 Oct 2026 04:39:01 +0200 Subject: [PATCH 3/3] Mark the packages whose tests read files outside their directory, found by the review (issue 1935) --- cmd/mesh-host/reads-outside | 1 + internal/upgrade/reads-outside | 1 + 2 files changed, 2 insertions(+) create mode 100644 cmd/mesh-host/reads-outside create mode 100644 internal/upgrade/reads-outside diff --git a/cmd/mesh-host/reads-outside b/cmd/mesh-host/reads-outside new file mode 100644 index 0000000..f6b2d87 --- /dev/null +++ b/cmd/mesh-host/reads-outside @@ -0,0 +1 @@ +These tests read files outside this directory (the whole catalogue, the repository, or its root files): mesh-build-go never keeps this package's verdict (issue 1935). diff --git a/internal/upgrade/reads-outside b/internal/upgrade/reads-outside new file mode 100644 index 0000000..f6b2d87 --- /dev/null +++ b/internal/upgrade/reads-outside @@ -0,0 +1 @@ +These tests read files outside this directory (the whole catalogue, the repository, or its root files): mesh-build-go never keeps this package's verdict (issue 1935).