From 302dcc098f9a8f12e9255408ae693299d286e82e Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 12 Nov 2026 22:16:40 +0100 Subject: [PATCH] H4 (review r2, A-307): the node-engine's manifest names no uses; its invoke of seat:mesh-grants.withheld is the edge MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds: design 47 G §635 --- module.json | 3 --- packaging/operator_keys_test.go | 4 ++++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/module.json b/module.json index d90fe2ba..a2d7d50d 100644 --- a/module.json +++ b/module.json @@ -39,9 +39,6 @@ ] } ], - "uses": [ - "mesh-grants" - ], "invokes": [ "seat:mesh-catalog.entry", {"verb": "seat:mesh-catalog.revision", "fields": ["none-yet"]}, diff --git a/packaging/operator_keys_test.go b/packaging/operator_keys_test.go index 72fd6773..6d07d6f6 100644 --- a/packaging/operator_keys_test.go +++ b/packaging/operator_keys_test.go @@ -63,6 +63,7 @@ func TestTheManifestConsumesTheBackupEvent(t *testing.T) { } var m struct { Consumes []string `json:"consumes"` + Uses []string `json:"uses"` Invokes []any `json:"invokes"` // a verb, or the long form {verb, fields} (§558) Config map[string]struct { Default any `json:"default"` @@ -73,6 +74,9 @@ func TestTheManifestConsumesTheBackupEvent(t *testing.T) { } // Design 47 G §630, §633, A-77: the recovery module's three verbs it asks, and its bound as a config key of 90. // §635, §558, §617: it invokes `withheld` and names no `uses`; the catalog's revision in the long form with the field none-yet. + if len(m.Uses) != 0 { + t.Errorf("uses is %v, want none: the invoke of seat:mesh-grants.withheld is the edge (§635, A-307)", m.Uses) + } for _, v := range []any{"seat:mesh-recovery.kept-points", "seat:mesh-recovery.restore-kept", "seat:mesh-recovery.snapshot-kept", "seat:mesh-grants.withheld", map[string]any{"verb": "seat:mesh-catalog.revision", "fields": []any{"none-yet"}}} { if !slices.ContainsFunc(m.Invokes, func(have any) bool { return reflect.DeepEqual(have, v) }) {