Keep main's rule for which haves run inside the node's own composition
mesh/delivery merged: source.main moved to novox/mesh-host@ffa63d25a066
mesh/check being carried to 76c7ddfc5227 on ffa63d25a066 | from a4713e2d28d7
mesh/delivery merged: source.main moved to novox/mesh-host@ffa63d25a066
mesh/check being carried to 76c7ddfc5227 on ffa63d25a066 | from a4713e2d28d7
Review round 1: a have naming no build in a phase but running is also written for a module that runs inside the node's own (waiting for a yes), so taking it out would drop its resources before the yes. The fp the held have now keeps already fixes postgres (issue 1289); a test drives an interrupted backup end to end. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL
This commit is contained in:
@@ -618,11 +618,7 @@ func (c *Composer) takeModuleHave(u agent.Update) bool {
|
||||
// A have that names nothing it runs, failed (the node could not compose a module it never ran: NotComposed), is
|
||||
// no module run inside the node's own composition: taken as one, it was composed from its manifest past its
|
||||
// build (issue 1126, review round 1 of the builds).
|
||||
// Nor is one in any phase but running that names nothing (held by a backup the node agent's restart
|
||||
// interrupted: postgres on novox, 2026-10-31, refused for its secret reader). Running with nothing named is
|
||||
// a module of the node's own (mesh-wireguard).
|
||||
runsNothing := h.FP == "" && h.Composed == "" &&
|
||||
(h.Phase == delivery.PhaseFailed || h.Build == "" && h.Phase != "" && h.Phase != delivery.PhaseRunning)
|
||||
runsNothing := h.Phase == delivery.PhaseFailed && h.FP == "" && h.Composed == ""
|
||||
in = h.Phase != delivery.PhaseRemoved && !runsNothing && !strings.HasPrefix(h.FP, delivery.SourcePrefix2)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user