Say running again when a provider's composition goes back to what runs while it waited for a yes (issue 774)
waitsForYes returned at once for a composition equal to what runs, and settleOne then found nothing to apply, so the have kept phase waiting-yes for a move that no longer existed (ace.postgres, novox.postgres, novox.keycloak and novox.mongodb on 2026-10-31). The have is now rewritten to running. Quick fix: rewrite the have where the equal composition is met. Thorough fix (not here): one place that writes a module's have from the settled state after every settle, so no early return can leave a stale phase.
This commit is contained in:
@@ -1577,6 +1577,11 @@ func (a *Agent) waitsForYes(ctx context.Context, module string, w wantNow, comp
|
||||
r, ran := a.running[module]
|
||||
if ran && r.Composed == comp.Dig && r.Phase != delivery.PhaseRemoved {
|
||||
a.mu.Unlock()
|
||||
// Composed back to what runs: a have still waiting for a yes for a move since gone says running again, or it waits
|
||||
// for a yes nobody needs (issue 774, 2026-10-31: four providers stayed waiting-yes once their consumers composed).
|
||||
if h, ok := a.env.Haves.Read(ctx, module); ok && h.Phase == string(delivery.PhaseWaitingYes) {
|
||||
a.writeHave(ctx, Have{Module: module, FP: r.FP, Composed: r.Composed, Phase: string(delivery.PhaseRunning), Sealed: h.Sealed})
|
||||
}
|
||||
return false
|
||||
}
|
||||
from, known := a.runningComposition(module)
|
||||
|
||||
Reference in New Issue
Block a user