From 8f1e5f25478deaccad7f4b5c671ae598ce6f0be5 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 2 Nov 2026 20:23:02 +0100 Subject: [PATCH] Stop judging the controller's manifest at genesis's step 9: the controller's repository is emptied MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test read mesh-controller/module.json beside the check, which no longer exists after the controller's removal (issue 1126, ADR 0593 ยง11), so it would fail every check of the node-engine. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL --- internal/bootstrap/genesis_form_test.go | 32 ------------------------- 1 file changed, 32 deletions(-) diff --git a/internal/bootstrap/genesis_form_test.go b/internal/bootstrap/genesis_form_test.go index dda3852..b196c84 100644 --- a/internal/bootstrap/genesis_form_test.go +++ b/internal/bootstrap/genesis_form_test.go @@ -237,35 +237,3 @@ func TestAFileNothingOfTheControllerWritesIsStillRefused(t *testing.T) { t.Fatalf("a file nothing writes was accepted, or refused without its name: %v", err) } } - -// The controller's own manifest, as the mesh runs it, passes step 9 (issue 597): in a merge check the -// node-engine's check has the controller cloned beside it (MESH_CHECK_BESIDE), where it must be; else a -// checkout beside this one; else it skips aloud. -// -// The checker places the controller beside this repository (mesh-delivery's besideRules, since R4g, issue 1295), so a -// MESH_CHECK_BESIDE without a mesh-controller directory, or without its module.json, fails. Only a run with no -// MESH_CHECK_BESIDE and no checkout beside this one (a developer's clone alone) skips aloud. -func TestTheControllersOwnManifestPassesStepNine(t *testing.T) { - var manifest []byte - if root := os.Getenv("MESH_CHECK_BESIDE"); root != "" { - if info, err := os.Stat(filepath.Join(root, "mesh-controller")); err != nil || !info.IsDir() { - t.Fatalf("the controller is not beside this check in MESH_CHECK_BESIDE=%s: the checker places mesh-controller beside the node-engine's check (mesh-delivery besideRules, issue 1295), and this test judges the controller's own manifest", root) - } - raw, err := os.ReadFile(filepath.Join(root, "mesh-controller", "module.json")) - if err != nil { - t.Fatalf("the controller is not beside this check in MESH_CHECK_BESIDE=%s: %v", root, err) - } - manifest = raw - } else if raw, err := os.ReadFile(filepath.Join("..", "..", "..", "mesh-controller", "module.json")); err == nil { - manifest = raw - } else { - t.Skip("NOT JUDGED: no controller beside this checkout and no MESH_CHECK_BESIDE; the merge check judges it") - } - wanted, err := theStepNineSecretsOf(t, manifest) - if err != nil { - t.Fatalf("genesis's step 9 refuses the controller the mesh runs: %v", err) - } - if wanted["MESH_STORE_INVENTORY"] != "inventory" { - t.Errorf("step 9 delivers %v", wanted) - } -}