selfcompose: what is read decides the trunk build's stand: the running event's manifest held, a running composition's build read as ranOf reads it (A-480a, A-482)
Builds: design 47 G A-480a, A-482
This commit is contained in:
@@ -550,22 +550,21 @@ func (c *Composer) needsAddressOf(node, module string) bool {
|
||||
}
|
||||
|
||||
// runsWithoutEntry says this node holds module on, as it runs it, and holds no entry of its wanted build nor of its running build
|
||||
// (c.mu held), and that neither its running event nor a composition it runs names the manifest of that build: the case where its
|
||||
// (c.mu held), and whose running event's manifest is not held (A-480a): the case where its
|
||||
// provisions are read from its trunk build (A-480a). A module built by hand before G says no running event (the engine says one only
|
||||
// of a build whose manifest it knows), so it counts as running when its have names a build in the phase running or held (A-482); one
|
||||
// wanted here that is heard running nowhere, runs nothing here and has no such have does not count.
|
||||
func (c *Composer) runsWithoutEntry(module string) bool {
|
||||
run := c.heard[c.env.Node][module]
|
||||
w, wanted := c.wants[module]
|
||||
if run.stopped || !wanted || w.Fp == "" || run.manifest != "" || !(c.runsHere(module) || c.haveRuns[module]) {
|
||||
if run.stopped || !wanted || w.Fp == "" || !(c.runsHere(module) || c.haveRuns[module]) {
|
||||
return false
|
||||
}
|
||||
if c.env.Running != nil {
|
||||
for _, r := range c.env.Running() {
|
||||
if r.Module == module && r.FP != "" {
|
||||
return false // its running composition says the build it runs: its manifest is read there, or its own words say it is not
|
||||
}
|
||||
}
|
||||
// What is read decides (A-480a: "can be read from neither"): the manifest its running event names, where that digest is held;
|
||||
// a running composition's build is read as frombus ranOf reads it, only through the entry of the wanted fingerprint (the
|
||||
// loop below), so a composition at another build reads nothing.
|
||||
if _, read := c.manifests[run.manifest]; run.manifest != "" && read {
|
||||
return false
|
||||
}
|
||||
for _, fp := range []string{w.Fp, run.fingerprint} {
|
||||
if k, held := c.keptEnt[fp]; held && k.entry.Module != "" {
|
||||
|
||||
Reference in New Issue
Block a user