H-A-177: move a data module without its restore point where no recovery holder is placed
The node-engine held every data-holding module's take-in for good: it asked the seat mesh-recovery for the restore point, and nothing answers because no holder of the seat is placed on the mesh (H §456). It now asks only where the assigner's placements it holds name a holder (and while they are not read yet); where none is placed it moves the module without a point and raises the finding restore-point-missing (warning, scope machine, id the module), cleared at the module's next take-in that takes its point. A holder placed that does not answer still holds the move. Builds: design 47 H §456, H-A-177
This commit is contained in:
@@ -714,6 +714,14 @@ func nodeAgent(ctx context.Context, opts options, signer ed25519.PublicKey, trus
|
||||
apply.UseEngineModule(composer.EngineModule) // the guard of the engine's own trees fixes no name (§527)
|
||||
env.Composed, env.SelfComposed, env.Policy, env.ComposedToday = composer, true, composer.Policy, composer.ComposedToday
|
||||
env.Recovery = recoveryEnv(session, composer)
|
||||
// A restore point is asked where the assigner's placements name a holder of mesh-recovery; where none is placed on the
|
||||
// mesh the module moves without one and says it as the finding restore-point-missing (design 47 H, H-A-177, H §456).
|
||||
env.Recovery.Placed = composer.RecoveryPlaced
|
||||
env.Recovery.PointMissing = func(ctx context.Context, module, words string, missing bool) {
|
||||
if err := seatwait.SayRestorePointMissing(ctx, findings, node, findings.observer(), module, words, missing, time.Now); err != nil {
|
||||
say("the finding that " + module + " moved without its restore point cannot be kept: " + err.Error())
|
||||
}
|
||||
}
|
||||
env.WhyUnmade, env.Waiting, env.RunningManifest = composer.WhyUnmade, composer.Waiting, composer.RunningManifest
|
||||
keptFetchFn := keptArtifactFetch(composer.KeptBuildOf, session.AskSeatOn, session.KeptObject)
|
||||
keptFetch.Store(&keptFetchFn)
|
||||
|
||||
@@ -125,7 +125,7 @@ func newFindingsOfTheNode(session *link.Session, node, module string, say func(s
|
||||
Module: module,
|
||||
Node: node,
|
||||
State: link.FindingsState{Session: session},
|
||||
Kinds: append([]string{seatwait.Kind, seatwait.HeldKind, seatwait.EntryNotFoundKind, seatwait.EntryUnansweredKind}, seatwait.NodeKinds...),
|
||||
Kinds: append([]string{seatwait.Kind, seatwait.HeldKind, seatwait.EntryNotFoundKind, seatwait.EntryUnansweredKind, seatwait.RestorePointMissingKind}, seatwait.NodeKinds...),
|
||||
Asked: condseat.SubjectFindingsAsked,
|
||||
Logf: func(format string, args ...any) { say(fmt.Sprintf(format, args...)) },
|
||||
Publish: session.PublishEvent,
|
||||
|
||||
Reference in New Issue
Block a user