composer: a store fetcher left out is held with its words, so its handed composition stays
Declared.Held carries the modules composeWithoutStoreFetchers leaves out (A-452: each stays on the build it runs). The store-address comment and code say A-461e: no address read without error holds only the fetchers, a fault reading the inputs still refuses the node. Builds: design 47 G-22 A-452, A-461, A-461e
This commit is contained in:
@@ -383,6 +383,13 @@ func TestTheStoreIsFoundByTheImageSeatsHolderAndItsListen(t *testing.T) {
|
||||
if why := d.LeftOutWhy[m]; !strings.Contains(why, "nothing provides") || !strings.Contains(why, "no artifact store") {
|
||||
t.Errorf("%s, which fetches from the store, waits with %q", m, why)
|
||||
}
|
||||
// Held, not only left out: it stays on the build it runs and its handed composition is kept (A-452).
|
||||
if why := d.Held[m]; !strings.Contains(why, "nothing provides") {
|
||||
t.Errorf("%s, which fetches from the store, is held with %q", m, why)
|
||||
}
|
||||
}
|
||||
if _, held := d.Held["plain"]; held {
|
||||
t.Errorf("a module that fetches nothing from the store is held")
|
||||
}
|
||||
if why, held := d.LeftOutWhy["plain"]; held {
|
||||
t.Errorf("a module that fetches nothing from the store waits: %q", why)
|
||||
|
||||
Reference in New Issue
Block a user