MH-7: the node-engine reads a module of a catalog revision as accepted: no verdict is read
The seat mesh-catalog keeps no state verdicts (H-A-79): frombus taken, the composer's parse and the composer's reading of a candidate drop the verdict branch and decode the manifest alone, a module in a catalog revision being accepted by being there; the composer no longer reads the request field Case.Verdicts (H-A-112). Tests that held a module by a verdict hold it by the decoder, or go. Builds: design 47 H, H-A-79, H-A-111, H-A-112 Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
This commit is contained in:
@@ -414,7 +414,7 @@ func (c *Composer) warm(ctx context.Context, origin *Composer, cand meshcatalog.
|
||||
}
|
||||
|
||||
// layCandidate lays the candidate's modules over the indexer's: each at its fingerprint, with its manifest's digest and
|
||||
// the indexer's verdict on it (read from its verdicts, none read taken as accepted); a module the candidate removes goes.
|
||||
// a module the candidate removes goes (design 47 H, H-A-79: the seat keeps no verdicts).
|
||||
// It answers the modules laid.
|
||||
func (c *Composer) layCandidate(ctx context.Context, cand meshcatalog.CandidatesByGroupValue) (map[string]bool, error) {
|
||||
touched := map[string]bool{}
|
||||
@@ -430,23 +430,6 @@ func (c *Composer) layCandidate(ctx context.Context, cand meshcatalog.Candidates
|
||||
continue // no fingerprint at the preview: composed as the trunk holds it
|
||||
}
|
||||
m := meshcatalog.ModulesByModuleValue{Fp2: cm.Fp2, Manifest: cm.Manifest, Repository: pull.Repository, Commit: pull.Head}
|
||||
if cm.Manifest != "" {
|
||||
key, err := meshcatalogclient.VerdictsKey(cm.Manifest)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
raw, err := c.get(ctx, buckets.Verdicts, key)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("the indexer's verdict on %s's manifest cannot be read: %w", module, err)
|
||||
}
|
||||
if raw != nil {
|
||||
v, err := meshcatalogclient.DecodeVerdict(raw)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("the indexer's verdict on %s's manifest cannot be read: %w", module, err)
|
||||
}
|
||||
m.Verdict, m.Problems, m.Warnings = v.State, v.Problems, v.Warnings
|
||||
}
|
||||
}
|
||||
c.mu.Lock()
|
||||
c.modules[module] = m
|
||||
c.mu.Unlock()
|
||||
|
||||
Reference in New Issue
Block a user