MH-7: the node-engine reads a module of a catalog revision as accepted: no verdict is read

The seat mesh-catalog keeps no state verdicts (H-A-79): frombus taken, the composer's parse and the composer's
reading of a candidate drop the verdict branch and decode the manifest alone, a module in a catalog revision being
accepted by being there; the composer no longer reads the request field Case.Verdicts (H-A-112). Tests that held a
module by a verdict hold it by the decoder, or go.

Builds: design 47 H, H-A-79, H-A-111, H-A-112

Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
This commit is contained in:
2026-11-20 04:24:53 +01:00
parent dd2b3a16df
commit e4d098c4b9
12 changed files with 50 additions and 731 deletions
+6 -14
View File
@@ -1454,7 +1454,7 @@ func (c *Composer) Policy(ctx context.Context, module string) string {
if err != nil {
return ""
}
parsed, held, err := c.taken(module, m, raw)
parsed, held, err := c.taken(module, raw)
if err != nil || held != "" {
return ""
}
@@ -1486,16 +1486,11 @@ func (c *Composer) Claims(_ context.Context, module, seat string) (claims, known
return a.Manifest.ClaimsSeat(seat), true
}
// taken is a module's manifest as this engine reads it (novox/hq ADR 0578 §3): decoded leniently, judging nothing, with
// the indexer's verdict from the module's value (a missing one is accepted). held is why the module is held, "" when it is
// not: a manifest the indexer refused, or one not read past a field this engine does not know. A field set aside is said
// taken is a module's manifest as this engine reads it: decoded leniently, judging nothing; a module in a catalog revision is
// accepted by being there (design 47 H, H-A-79, H-A-111). held is why the module is held, "" when it is not: one not read past
// a field this engine does not know. A field set aside is said
// once, and an error is returned only for bytes that are no manifest, which the caller says in its own words.
func (c *Composer) taken(module string, m meshcatalog.ModulesByModuleValue, raw []byte) (man catalogue.Manifest, held string, err error) {
if v := meshcatalogclient.ModuleVerdict(module, m); v != nil {
if refused, _ := meshcatalogclient.TakeVerdict(v); refused {
return catalogue.Manifest{}, meshcatalogclient.VerdictWhy(*v), nil
}
}
func (c *Composer) taken(module string, raw []byte) (man catalogue.Manifest, held string, err error) {
man, err = catalogue.Decode(raw)
if err != nil {
c.sayOnceEach("the manifest of " + module + " does not decode, and the module is held: " + err.Error())
@@ -1552,10 +1547,7 @@ func (c *Composer) certificateWanted(ctx context.Context, r reader, p meshmodule
if err != nil {
continue
}
c.mu.Lock()
mod := c.modules[m.Module]
c.mu.Unlock()
parsed, held, err := c.taken(m.Module, mod, raw)
parsed, held, err := c.taken(m.Module, raw)
if err != nil || held != "" {
continue // held or not read: it asks none, and its refusal is named by the composition
}