MH-7: the node-engine reads a module of a catalog revision as accepted: no verdict is read

The seat mesh-catalog keeps no state verdicts (H-A-79): frombus taken, the composer's parse and the composer's
reading of a candidate drop the verdict branch and decode the manifest alone, a module in a catalog revision being
accepted by being there; the composer no longer reads the request field Case.Verdicts (H-A-112). Tests that held a
module by a verdict hold it by the decoder, or go.

Builds: design 47 H, H-A-79, H-A-111, H-A-112

Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy
This commit is contained in:
2026-11-20 04:24:53 +01:00
parent dd2b3a16df
commit e4d098c4b9
12 changed files with 50 additions and 731 deletions
-38
View File
@@ -624,44 +624,6 @@ func TestTheNodeComposesItsWantsFromTheBus(t *testing.T) {
strings.Contains((*told)[0], "held lemurs") {
t.Errorf("the agent was told %q, want de-spiegel held alone, in its config form's words, without its routes", *told)
}
// Issue 774, 2026-10-30 19:13: a manifest the mesh refuses (power's bar item at mesh-catalog ca8d6f33, captured, with
// attributes its bar places by none of) refused every node's composition and failed all its modules. Now power is
// held alone, naming why, and lemurs is handed.
power, err := os.ReadFile("testdata/power-ca8d6f33.module.json")
if err != nil {
t.Fatal(err)
}
c4, told4 := fresh(env.Get)
powerFP := meshcatalogclient.SourcePrefix2 + strings.Repeat("c", 64)
powerHalf := catalogHalf{}
powerHalf.add(t, "power", powerFP, string(power))
powerEntry := powerHalf[powerFP]
// The verdict the catalog half's entry carries on the captured manifest (ADR 0578): the engine judges nothing, it takes this.
powerEntry.Repository, powerEntry.Commit, powerEntry.Verdict = "novox/mesh-catalog", "ca8d6f33", meshcatalogclient.VerdictRefused
powerEntry.Inputs = &meshcatalog.EntryInputs{Problems: []string{`bar item "shows" is none of them`}}
c4.mu.Lock()
c4.keptEnt[powerFP] = keptEntry{entry: powerEntry}
c4.mu.Unlock()
c4.wants["power"] = meshwants.WantsByWantNodeModuleValue{Fp: powerFP, Self: true}
p4 := c4.assignments["n1"]
p4.Modules = append(append([]meshmoduleassigner.PlacedModule{}, p4.Modules...), meshmoduleassigner.PlacedModule{Module: "power"})
c4.assignments["n1"] = p4
handed4 := map[string]agent.Update{}
for _, u := range c4.compose(ctx) {
handed4[u.Key] = u
}
if u, ok := handed4[lemursKey3]; !ok || u.Deleted {
t.Errorf("lemurs is not handed beside power's refused manifest: %v (told %q)", handed4, *told4)
}
if len(*told4) != 1 || !strings.HasPrefix((*told4)[0], "held power: ") || !strings.Contains((*told4)[0], `"shows" is none of them`) {
t.Errorf("the agent was told %q, want power held alone, naming its item", *told4)
}
// Issue 1921: the composition verb's held says what holds power and the build it would be composed at, as the input a
// check's composer reads says it.
if why := c4.LastHeld()["power"]; !strings.Contains(why, `"shows" is none of them`) ||
!strings.Contains(why, "held by its manifest's verdict, at the build "+powerFP) {
t.Errorf("the last pass held power for %q, want its verdict and its build named", why)
}
// Review of issue 774 (the kept read): mesh-wireguard, which the mesh provides and which never has a fingerprint, is
// folded in the node's own and composed from the manifest mesh-sdk provides (overlay.ProvidedManifest), not from
// what runs nor the kept declaration: with nothing running (the kept read retired, Running empty) the node's own