Leave a record another module's composition now holds, whatever its type, instead of removing it in the node's own apply; a removed module holds nothing back (issue 1944, issue 1945)

internal/apply/module_scope_test.go

@@ -111,3 +111,38 @@ func TestARecordWithoutAnOwnerBelongsToTheModuleItsIdNames(t *testing.T) {
 		t.Fatalf("a's file exists %v, b's file exists %v", exists(fa), exists(fb))
 	}
 }
+
+// A resource that leaves the node's own composition for its module's own is that module's now: the node's own apply
+// leaves it as it is, whatever its type, until the module's own apply takes it (issue 1945, live on 2026-10-25 at 02:32:
+// shanks and g14 lost systemd-resolved's guard, its resolver files and sudo's operator file, ace qbittorrent's server,
+// because the node's own apply removed every record no longer in it, the others holding the very same resources or not).
+func TestAResourceThatMovedToItsModulesCompositionIsLeftByTheNodesOwnApply(t *testing.T) {
+	dir := t.TempDir()
+	fact := filepath.Join(dir, "suffix")
+	gone := filepath.Join(dir, "gone.conf")
+	own := declare(t, `{"id":"systemd-resolved.fact-suffix","type":"file","path":"`+fact+`","content":"mesh\n"},
+	  {"id":"old.gone","type":"file","path":"`+gone+`","content":"g\n"}`)
+	_, state, err := ApplyModule(context.Background(), archHost(t), own, Scope{Module: store.NodeModule},
+		state0(), store.OriginDeclared, noServices, nil, nil, nil, nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	// systemd-resolved now has a composition of its own, not applied yet; old.gone is no module's any more.
+	moved := declare(t, `{"id":"systemd-resolved.fact-suffix","type":"file","path":"`+fact+`","content":"mesh\n","module":"systemd-resolved"}`)
+	report, state, err := ApplyModule(context.Background(), archHost(t), &declaration.Declaration{},
+		Scope{Module: store.NodeModule, Others: moved.Resources}, state, store.OriginDeclared, noServices, nil, nil, nil, nil)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !exists(fact) {
+		t.Fatalf("the moved resource was removed: %+v", outcomeOf(report, "systemd-resolved.fact-suffix"))
+	}
+	if exists(gone) {
+		t.Fatal("a resource no composition holds any more was kept")
+	}
+	if _, still := state.Find("systemd-resolved.fact-suffix"); !still {
+		t.Fatal("the moved resource's record was dropped, so its module's apply would not know it")
+	}
+}
+
+func state0() store.State { return store.State{} }