H-A-178: key restore-point-missing by module and node; test the placements read

Findings are keyed by scope, id and kind across the mesh, so the module
alone as the id let two machines clear each other's restore-point-missing:
its id is now <module>.<node>, as a held module's is. Before the watch of
the assignments has caught up the point is asked as before and a missing
answer holds the move (H-A-178, built in d217056c); the composer's Watch
test now shows RecoveryPlaced answers read only once the assignments are
caught up.

Builds: design 47 H §456, H-A-177, H-A-178
This commit is contained in:
2026-11-20 19:03:01 +01:00
parent d217056cf7
commit e7177db3cc
3 changed files with 20 additions and 7 deletions
+7
View File
@@ -286,6 +286,10 @@ func TestTheNodeComposesItsWantsFromTheBus(t *testing.T) {
c.holdEntry(t, "oldie", oldieFp, oldie)
b.put(t, buckets.Wants, "want.n1.lemurs", want)
b.put(t, buckets.Wants, "want.n1.node", nodeWant)
// Design 47 H, H-A-177, H-A-178: before the watch of the assignments has caught up, the placements are not read.
if _, read := c.RecoveryPlaced(); read {
t.Error("the placements are read before the watch of the assignments caught up")
}
for _, bucket := range []string{buckets.Wants, buckets.Assignments, buckets.Have, ResolvedBucket} {
b.send(bucket, agent.Update{Caught: true})
}
@@ -294,6 +298,9 @@ func TestTheNodeComposesItsWantsFromTheBus(t *testing.T) {
for {
u := next(t, out)
if u.Caught {
if placed, read := c.RecoveryPlaced(); !read || placed {
t.Errorf("once the assignments are caught up RecoveryPlaced answers placed %v read %v, want read with no holder", placed, read)
}
break
}
c, err := compositions.Decode(u.Value)