Repoint ADR references after HQ consolidated 65 records to 23
96 comments across the two repos named records that no longer exist. Each now points at the consolidated record that holds its reasoning -- ADR 0034 (a test defends a decision) is 0017, the eight host records are 0005, the four lab records are 0016. Worth noting for next time: these are references from outside HQ, so renumbering there is not free. It cost 38 files here.
This commit is contained in:
@@ -3,7 +3,7 @@
|
||||
// Reported upward and never asked downward (novox/hq 03-DESIGN/01-to-be/05-the-node-host.md).
|
||||
// Everything here is read from the machine at the moment of asking — nothing is remembered,
|
||||
// nothing is derived from a file that says what the machine ought to be
|
||||
// (novox/hq ADR 0035).
|
||||
// (novox/hq ADR 0018).
|
||||
package inventory
|
||||
|
||||
import (
|
||||
@@ -39,7 +39,7 @@ type Inventory struct {
|
||||
|
||||
// ObservedAt is when this was read. An inventory with no timestamp cannot be told from a
|
||||
// stale one, and a node that has been unreachable for a week is an ordinary situation
|
||||
// (novox/hq ADR 0036) rather than an error — so the age of the observation is part of it.
|
||||
// (novox/hq ADR 0004) rather than an error — so the age of the observation is part of it.
|
||||
ObservedAt time.Time `json:"observed_at"`
|
||||
|
||||
// Unreadable lists what could not be determined, and why. An absent field and a field that
|
||||
|
||||
@@ -64,7 +64,7 @@ func TestMemoryIsReadOrReportedMissing(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestTheInventorySaysWhenItWasTaken(t *testing.T) {
|
||||
// A node unreachable for a week is an ordinary situation (novox/hq ADR 0036), so an
|
||||
// A node unreachable for a week is an ordinary situation (novox/hq ADR 0004), so an
|
||||
// inventory that cannot be told from a stale one is missing the fact that matters.
|
||||
before := time.Now().UTC()
|
||||
inv := Collect(context.Background(), nil, nil, time.Second)
|
||||
@@ -79,7 +79,7 @@ func TestTheInventorySaysWhenItWasTaken(t *testing.T) {
|
||||
|
||||
func TestTheHostDoesNotNameTheNode(t *testing.T) {
|
||||
// A node's name is assigned by the mesh. A host that named itself would be deciding
|
||||
// something, which is precisely what novox/hq ADR 0037 forbids it to do.
|
||||
// something, which is precisely what novox/hq ADR 0005 forbids it to do.
|
||||
inv := Collect(context.Background(), nil, nil, time.Second)
|
||||
hostname, _ := os.Hostname()
|
||||
|
||||
@@ -91,7 +91,7 @@ func TestTheHostDoesNotNameTheNode(t *testing.T) {
|
||||
// --- against this machine ---------------------------------------------------------------
|
||||
|
||||
func TestAgainstThisMachine_inventoryIsTrue(t *testing.T) {
|
||||
// novox/hq ADR 0034: behaviour against a real system is tested alongside, not mocked.
|
||||
// novox/hq ADR 0017: behaviour against a real system is tested alongside, not mocked.
|
||||
inv := Collect(context.Background(), nil, profile.Default(nil), 10*time.Second)
|
||||
|
||||
if inv.Machine == "" {
|
||||
|
||||
Reference in New Issue
Block a user