Repoint ADR references after HQ consolidated 65 records to 23
96 comments across the two repos named records that no longer exist. Each now points at the consolidated record that holds its reasoning -- ADR 0034 (a test defends a decision) is 0017, the eight host records are 0005, the four lab records are 0016. Worth noting for next time: these are references from outside HQ, so renumbering there is not free. It cost 38 files here.
This commit is contained in:
@@ -111,7 +111,7 @@ func firstLine(s string) string {
|
||||
// privileged reports whether the host can change this machine at all.
|
||||
//
|
||||
// Reported as a capability rather than checked at startup on purpose: a host that cannot act
|
||||
// is still a host that can report, and novox/hq ADR 0036 says what varies between nodes lives
|
||||
// is still a host that can report, and novox/hq ADR 0004 says what varies between nodes lives
|
||||
// here rather than in the definition of a node.
|
||||
type privileged struct{}
|
||||
|
||||
|
||||
@@ -44,7 +44,7 @@ type Detector interface {
|
||||
// Runner executes a command. Replaceable in tests for the pure-logic layer ONLY — every
|
||||
// detector in this package is exercised against the real machine as well, because a test that
|
||||
// fakes the system under detection asserts that the fake behaves as expected
|
||||
// (novox/hq ADR 0034).
|
||||
// (novox/hq ADR 0017).
|
||||
type Runner func(ctx context.Context, name string, args ...string) (stdout string, err error)
|
||||
|
||||
// ExecRunner runs a real command, with output captured and stdin closed.
|
||||
@@ -97,7 +97,7 @@ func (p Profile) Missing() []string {
|
||||
// Detect runs every detector and collects the verdicts.
|
||||
//
|
||||
// A detector that fails does not fail the profile. This is deliberately NOT the rule in
|
||||
// novox/hq ADR 0008: that rule governs applying state, where a failed step means the machine
|
||||
// novox/hq ADR 0010: that rule governs applying state, where a failed step means the machine
|
||||
// is not what was asked for. Detection is the opposite — a failed probe is a finding, and the
|
||||
// finding is "absent, because the probe failed", which is exactly what a caller needs to know.
|
||||
// Aborting would replace one legible absence with total ignorance.
|
||||
|
||||
@@ -8,7 +8,7 @@ import (
|
||||
"time"
|
||||
)
|
||||
|
||||
// Against the real machine. novox/hq ADR 0034: structure and logic are tested first, behaviour
|
||||
// Against the real machine. novox/hq ADR 0017: structure and logic are tested first, behaviour
|
||||
// against a real system alongside, and mocking the boundary is forbidden — a test that fakes
|
||||
// the system under detection asserts that the fake behaves as expected.
|
||||
//
|
||||
|
||||
@@ -8,7 +8,7 @@ import (
|
||||
"time"
|
||||
)
|
||||
|
||||
// The decision each test defends is named in the test, per novox/hq ADR 0034. These cover
|
||||
// The decision each test defends is named in the test, per novox/hq ADR 0017. These cover
|
||||
// structure and logic; profile_system_test.go covers the same detectors against the real
|
||||
// machine, because a test that fakes the system under detection asserts only that the fake
|
||||
// behaves as expected.
|
||||
@@ -57,7 +57,7 @@ func TestEveryVerdictSaysHowItKnows(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestDetectionSurvivesAFailingProbe(t *testing.T) {
|
||||
// Deliberately NOT ADR 0008. That rule governs APPLYING state, where a failed step means
|
||||
// Deliberately NOT ADR 0010. That rule governs APPLYING state, where a failed step means
|
||||
// the machine is not what was asked for. A failed probe is a finding, and aborting would
|
||||
// replace one legible absence with total ignorance of the rest.
|
||||
only := func(ctx context.Context, name string, args ...string) (string, error) {
|
||||
|
||||
Reference in New Issue
Block a user