R4g finish: merge-check.sh gone, reads-outside markers (issues 1295, 1935) #133

Merged

jschoubben merged 4 commits from feat/r4g-finish into main 2026-10-24 20:57:24 +00:00

Conversation 2 Commits 4 Files Changed 5

+8 -6

mesh-tools commented 2026-10-24 11:49:23 +00:00

Member

Copy Link

Copy Source

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan.

This member: merge-check.sh gone, its checks as Go tests and skips as failures (1295); reads-outside markers (1935). Try at 7618f661 PASS 8m5s; unchanged since review round 2.

Reviewed-by: review-r4g-finish@shanks at 13bdcb694b
Pushed-by: lead-47@shanks

Delivery group feat/r4g-finish (design 47, milestone R4g+R5, its finish): hq, mesh-sdk, mesh-controller, mesh-delivery, mesh-catalog, mesh-media-catalog, mesh-host. One Approve, one delivery plan. This member: merge-check.sh gone, its checks as Go tests and skips as failures (1295); reads-outside markers (1935). Try at 7618f661 PASS 8m5s; unchanged since review round 2. Reviewed-by: review-r4g-finish@shanks at 13bdcb694be02ee792a2daa48545b09d3452c0e8 Pushed-by: lead-47@shanks

mesh-tools added 4 commits 2026-10-24 11:49:23 +00:00

Fail, not skip, when the checker places no controller beside the node-engine (issue 1295) 7618f661ea

Mark the packages whose tests read files outside their directory, so mesh-build-go never keeps their verdict (issue 1935) b4f6537f80

Merge remote-tracking branch 'origin/feat/r4g-finish-1935' into HEAD 89ebd0eefe

Mark the packages whose tests read files outside their directory, found by the review (issue 1935) 13bdcb694b

mesh-tools commented 2026-10-24 11:49:29 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-host@13bdcb694be0 — delivered since 2026-10-24T21:11:25Z

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

• tier 0: mesh-host
• ace: receives mesh-host
• g14: receives mesh-host
• novox: receives mesh-host
• shanks: receives mesh-host
• grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine

Group feat/r4g-finish: novox/hq@2249d30151, novox/mesh-catalog@2fabbe556e, novox/mesh-controller@ecbb317dc3, novox/mesh-delivery@65496fc4f7, novox/mesh-host@13bdcb694b, novox/mesh-media-catalog@6392690b90, novox/mesh-sdk@bfc3883af9

• composed together: pass — the checker's verdict at the members' heads (590ced519c20)

Machines

• adwaita on every machine running it: sent
• blueman on every machine running it: sent
• brother on every machine running it: sent
• forticlient on every machine running it: sent
• i3 on every machine running it: sent
• lemurs on every machine running it: sent
• mesh-build-image on every machine running it: sent
• mesh-build-node on every machine running it: sent
• mesh-delivery-builder on every machine running it: sent
• mesh-delivery-checker on every machine running it: sent
• mesh-delivery-gate on every machine running it: sent
• mesh-delivery-indexer on every machine running it: sent
• mesh-delivery-teller on every machine running it: sent
• mesh-delivery-watchman on every machine running it: sent
• mesh-host on every machine running it: sent
• mesh-issues on every machine running it: sent
• mesh-knowledge on every machine running it: sent
• mesh-mail on every machine running it: sent
• mesh-mail-notifier on every machine running it: sent
• mesh-mail-reader on every machine running it: sent
• mesh-provisioner-client on every machine running it: sent
• mesh-sdk on every machine running it: sent
• minio on every machine running it: sent
• networkmanager on every machine running it: sent
• nextcloud-client on every machine running it: sent
• nm-applet on every machine running it: sent
• openrazer on every machine running it: sent
• pacman on every machine running it: sent
• polychromatic on every machine running it: sent
• postgres on every machine running it: sent
• slack on every machine running it: sent
• systemd-networkd on every machine running it: sent
• xorg on every machine running it: sent
• xterm on every machine running it: sent
• mesh-controller on every machine running it: sent
• mesh-build-go on every machine running it: sent
• mesh-delivery-assigner on every machine running it: sent

Transitions

• 2026-10-24 11:49 (new) → proposed (announced): novox/mesh-host#133's head announced
• 2026-10-24 12:06 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-24 12:06 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
• 2026-10-24 12:52 rejected → proposed (recheck): its mesh/check judged it again: failed: the composition: the manifest of pacman cannot be read: this manifest cannot be used: | 13bdcb694b on 3c3628c…
• 2026-10-24 12:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-24 12:52 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed
• 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass 13bdcb694b on 3c3628c0ce | unit 4575 run, 5233 kept, 13 skipped | integration 4618 run, 6407 kept, 21 skipped …
• 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
• 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
• 2026-10-24 20:59 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
• 2026-10-24 20:59 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
• 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@13bdcb694be0` — **delivered** since 2026-10-24T21:11:25Z **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine **Group** `feat/r4g-finish`: novox/hq@2249d30151e8, novox/mesh-catalog@2fabbe556e73, novox/mesh-controller@ecbb317dc324, novox/mesh-delivery@65496fc4f7a6, novox/mesh-host@13bdcb694be0, novox/mesh-media-catalog@6392690b90c2, novox/mesh-sdk@bfc3883af980 - composed together: pass — the checker's verdict at the members' heads (590ced519c20) **Machines** - adwaita on every machine running it: sent - blueman on every machine running it: sent - brother on every machine running it: sent - forticlient on every machine running it: sent - i3 on every machine running it: sent - lemurs on every machine running it: sent - mesh-build-image on every machine running it: sent - mesh-build-node on every machine running it: sent - mesh-delivery-builder on every machine running it: sent - mesh-delivery-checker on every machine running it: sent - mesh-delivery-gate on every machine running it: sent - mesh-delivery-indexer on every machine running it: sent - mesh-delivery-teller on every machine running it: sent - mesh-delivery-watchman on every machine running it: sent - mesh-host on every machine running it: sent - mesh-issues on every machine running it: sent - mesh-knowledge on every machine running it: sent - mesh-mail on every machine running it: sent - mesh-mail-notifier on every machine running it: sent - mesh-mail-reader on every machine running it: sent - mesh-provisioner-client on every machine running it: sent - mesh-sdk on every machine running it: sent - minio on every machine running it: sent - networkmanager on every machine running it: sent - nextcloud-client on every machine running it: sent - nm-applet on every machine running it: sent - openrazer on every machine running it: sent - pacman on every machine running it: sent - polychromatic on every machine running it: sent - postgres on every machine running it: sent - slack on every machine running it: sent - systemd-networkd on every machine running it: sent - xorg on every machine running it: sent - xterm on every machine running it: sent - mesh-controller on every machine running it: sent - mesh-build-go on every machine running it: sent - mesh-delivery-assigner on every machine running it: sent **Transitions** - 2026-10-24 11:49 (new) → proposed (announced): novox/mesh-host#133's head announced - 2026-10-24 12:06 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 12:06 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-24 12:52 rejected → proposed (recheck): its mesh/check judged it again: failed: the composition: the manifest of pacman cannot be read: this manifest cannot be used: | 13bdcb694be0 on 3c3628c… - 2026-10-24 12:52 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 12:52 checked → rejected (refused): the gate failed or could not run, or the repository's own check failed - 2026-10-24 14:20 rejected → proposed (recheck): its mesh/check judged it again: pass 13bdcb694be0 on 3c3628c0ce46 | unit 4575 run, 5233 kept, 13 skipped | integration 4618 run, 6407 kept, 21 skipped … - 2026-10-24 14:20 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-24 14:20 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-24 20:59 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-24 20:59 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-24 21:11 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.

mesh-tools commented 2026-10-24 19:55:05 +00:00

Author

Member

Copy Link

Copy Source

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

jschoubben merged commit 285395d523 into main 2026-10-24 20:57:24 +00:00

jschoubben deleted branch feat/r4g-finish 2026-10-24 20:57:24 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#133