Never remove a module's resources while its own composition waits to be applied (issue 1944) #136

2026-10-25T01:05:00Z

mesh-tools commented

2026-10-25 01:05:00 +00:00

After the R6 switch, a node's own apply removed the resources of modules that had just moved to compositions of their own but could not apply yet (want held for the credential): shanks, g14 and ace lost their resolver, sudo's operator file, okioki's state, qbittorrent's container and more (issue 1944 notes 11-14). Now: a module whose own composition the node's bucket holds and the agent does not run is held out of every apply and removal (2bfde7d); removeOrphan leaves any record another module's composition now holds, and a removed want holds nothing back (e62c32c); the node's own apply waits, naming the keys, while a module's composition (the one its want names, or its newest) cannot be read or is refused (fa9e448, ecf142e).

Goes out BEFORE mesh-controller fix/r6-fp2-seen, which registers the builds lost across the controller's restart and so moves those modules.

Tries: try-1792890091171704239 passed on ecf142e.
Reviewed-by: reviewer-r6m@shanks at fa9e4483c8 (ecf142e is the reviewer's own note folded in)
Pushed-by: lead-47@shanks

After the R6 switch, a node's own apply removed the resources of modules that had just moved to compositions of their own but could not apply yet (want held for the credential): shanks, g14 and ace lost their resolver, sudo's operator file, okioki's state, qbittorrent's container and more (issue 1944 notes 11-14). Now: a module whose own composition the node's bucket holds and the agent does not run is held out of every apply and removal (2bfde7d); removeOrphan leaves any record another module's composition now holds, and a removed want holds nothing back (e62c32c); the node's own apply waits, naming the keys, while a module's composition (the one its want names, or its newest) cannot be read or is refused (fa9e448, ecf142e). Goes out BEFORE mesh-controller fix/r6-fp2-seen, which registers the builds lost across the controller's restart and so moves those modules. Tries: try-1792890091171704239 passed on ecf142e. Reviewed-by: reviewer-r6m@shanks at fa9e4483c821f0d3406c16fc6d9766484c064889 (ecf142e is the reviewer's own note folded in) Pushed-by: lead-47@shanks

mesh-tools added 4 commits 2026-10-25 01:05:00 +00:00

Hold out a module whose own composition waits to be applied, so the node's own apply never removes the resources it moved there (issue 1944, issue 1945) 2bfde7d659

Leave a record another module's composition now holds, whatever its type, instead of removing it in the node's own apply; a removed module holds nothing back (issue 1944, issue 1945) e62c32c8c3

Hold back the node's own apply while a module's composition cannot be read or is refused, naming it (issue 1944, issue 1945) fa9e4483c8

Let only a module's wanted or newest composition hold the node's own apply back, never a stale refused one (issue 1945)

mesh/delivery merged: source.main moved to novox/mesh-host@cf455bc4fe3e

Details

mesh/check pass ecf142e4513f on cf455bc4fe3e | unit 292 run, 1033 kept, 5 skipped | integration 295 run, 1034 kept, 4 skipped | over bound: unit (slow…

ecf142e451

mesh-tools commented

2026-10-25 01:05:05 +00:00

Delivery novox/mesh-host@ecf142e4513f — merged since 2026-10-25T09:23:29Z

Source — source.main moved to novox/mesh-host@cf455bc4fe. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-10-25 01:05 (new) → proposed (announced): novox/mesh-host#136's head announced
2026-10-25 01:06 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail
2026-10-25 09:23 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-host@ecf142e4513f` — **merged** since 2026-10-25T09:23:29Z **Source** — source.main moved to novox/mesh-host@cf455bc4fe3e. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-10-25 01:05 (new) → proposed (announced): novox/mesh-host#136's head announced - 2026-10-25 01:06 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail - 2026-10-25 09:23 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

jschoubben merged commit cf455bc4fe into main

2026-10-25 09:23:28 +00:00

jschoubben deleted branch fix/r6-node-own-keeps-moved

2026-10-25 09:23:29 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#136