The node agent answers a placement candidate in shadow, applies nothing, and keeps its own sealed values in its have (issue 1126, ADR 0559 §4) #151

2026-10-27T01:49:53Z

mesh-tools commented

2026-10-27 01:49:53 +00:00

Milestone L2b (issue 1126), ADR 0559 §4. Delivery group feat/1126-l2b; pins mesh-sdk cadd7b1b exactly.

internal/selfcompose/shadow.go: the shadow composer watches every candidate key, lays each group's keys over the trunk's placement, composes with the node's own sealed values, applies nothing, and answers in .node only when the answer changes; Keep restarts it with backoff, each run on its own context from empty state.
The node's own composition carries its sealed values in its have, so a node-engine restart no longer re-seals and re-applies it (review round 3 finding 1 of the earlier L2); Policy takes the agent's context.
H8 extended: a candidate equal to the placement is answered 'same' at its head and revision, and nothing moves.

Safety (review question 3): nothing here applies differently on a node until it is placed; delivering this changes nothing a node runs.
Rule bent, said: the node-agent integration tests (H8) were run locally against an embedded bus, seconds and no mesh build capacity; that run found H8's missing facts stream.
Tests: whole unit suite, go vet -tags integration pass; no new test functions.

Reviewed-by: review-l2b@shanks at 1803d25c3a

Milestone L2b (issue 1126), ADR 0559 §4. Delivery group feat/1126-l2b; pins mesh-sdk cadd7b1b exactly. - internal/selfcompose/shadow.go: the shadow composer watches every candidate key, lays each group's keys over the trunk's placement, composes with the node's own sealed values, applies nothing, and answers in <node>.node only when the answer changes; `Keep` restarts it with backoff, each run on its own context from empty state. - The node's own composition carries its sealed values in its have, so a node-engine restart no longer re-seals and re-applies it (review round 3 finding 1 of the earlier L2); `Policy` takes the agent's context. - H8 extended: a candidate equal to the placement is answered 'same' at its head and revision, and nothing moves. Safety (review question 3): nothing here applies differently on a node until it is placed; delivering this changes nothing a node runs. Rule bent, said: the node-agent integration tests (H8) were run locally against an embedded bus, seconds and no mesh build capacity; that run found H8's missing facts stream. Tests: whole unit suite, go vet -tags integration pass; no new test functions. Reviewed-by: review-l2b@shanks at 1803d25c3a6708e9a54ccede458a2539940e0f09

mesh-tools added 5 commits 2026-10-27 01:49:53 +00:00

Keep the node's own composition's sealed values in its key and read a policy within the agent's context, so a restart applies nothing again (issue 1126) 0474a2a3cb

Answer every placement candidate in shadow in the node's own key, applying nothing, so a placement change is checked by the nodes it places before it merges (issue 1126, ADR 0559 §4) fb0cdabe25

Extend H8 with a placement candidate the node answers same and applies nothing for, and pin mesh-sdk's group head (issue 1126) fbc6d6330f

Begin the shadow composer again with a backoff when an input cannot be watched yet, and pin mesh-sdk's fixed head, so a node answers candidates for the whole link (issue 1126, review of L2b round 1) d56c576e9a

Watch afresh and read from nothing at each shadow run, so a candidate deleted while it was down is not answered and no earlier watch stays open (issue 1126, review of L2b round 2)

mesh/delivery merged: source.main moved to novox/mesh-host@0d22776b20ef

Details

mesh/delivery-group group feat/1126-l2b merged: every member is merged

Details

mesh/check checking 1803d25c3a67 on 0d22776b20ef | novox/mesh-host#151 in group feat/1126-l2b

1803d25c3a

mesh-tools commented

2026-10-27 01:49:59 +00:00

Delivery novox/mesh-host@1803d25c3a67 — merged since 2026-10-27T07:21:23Z

Source — source.main moved to novox/mesh-host@0d22776b20. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group feat/1126-l2b: novox/hq@043f8ecf9c, novox/mesh-catalog@2ac511ce6b, novox/mesh-delivery@06d4f45e18, novox/mesh-host@1803d25c3a, novox/mesh-sdk@cadd7b1b2f

Transitions

2026-10-27 01:49 (new) → proposed (announced): novox/mesh-host#151's head announced
2026-10-27 01:49 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-10-27 07:21 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/mesh-host@1803d25c3a67` — **merged** since 2026-10-27T07:21:23Z **Source** — source.main moved to novox/mesh-host@0d22776b20ef. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `feat/1126-l2b`: novox/hq@043f8ecf9cfa, novox/mesh-catalog@2ac511ce6b19, novox/mesh-delivery@06d4f45e1885, novox/mesh-host@1803d25c3a67, novox/mesh-sdk@cadd7b1b2f8f **Transitions** - 2026-10-27 01:49 (new) → proposed (announced): novox/mesh-host#151's head announced - 2026-10-27 01:49 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-10-27 07:21 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools commented

2026-10-27 01:50:11 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools commented

2026-10-27 01:50:19 +00:00

mesh-delivery: the operator's Approve of this pull request's merge into main is ended: a head it covers moved on: the heads it covers are no longer the group's heads. Nothing is merged on it. The operator is asked again once the checks pass at the new head.

mesh-tools merged commit 0d22776b20 into main

2026-10-27 07:21:20 +00:00

mesh-tools deleted branch feat/1126-l2b

2026-10-27 07:21:20 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#151