The own resolver's test reads the options from the catalog's template (issue 1748, ADR 0678) #225

Merged

mesh-tools merged 1 commits from fix/1748-resolver-wait into main 2026-11-12 17:52:55 +00:00

Conversation 1 Commits 1 Files Changed 1

+11 -1

mesh-tools commented 2026-11-12 17:20:21 +00:00

Member

Copy Link

Copy Source

Issue 1748, group fix/1748-resolver-wait with mesh-catalog (either merge order).

Builds design 50 resolver-wait §3 (hq #587), from ADR 0678: internal/compose/resolution/node_resolver_test.go TestTheCataloguesResolverComposesOnAMachine takes the options line from the catalog's systemd-resolved template instead of the literal timeout:1 attempts:2 edns0, so it holds before and after the catalog's change (the second time this kind was met: a catalog value restated in another repository's test). The names check's bound (waitOf) is unchanged. No new test function.

Acceptance 1748/AC3 (issue 1748 note 39).

Reviewed-by: mesh-code-reviewer@shanks at 8dc186944e

Issue 1748, group fix/1748-resolver-wait with mesh-catalog (either merge order). Builds design 50 resolver-wait §3 (hq #587), from ADR 0678: `internal/compose/resolution/node_resolver_test.go` `TestTheCataloguesResolverComposesOnAMachine` takes the options line from the catalog's systemd-resolved template instead of the literal `timeout:1 attempts:2 edns0`, so it holds before and after the catalog's change (the second time this kind was met: a catalog value restated in another repository's test). The names check's bound (`waitOf`) is unchanged. No new test function. Acceptance 1748/AC3 (issue 1748 note 39). Reviewed-by: mesh-code-reviewer@shanks at 8dc186944e7d7cd33911b1730e2845cf7cd67dd1

mesh-tools added 1 commit 2026-11-12 17:20:21 +00:00

fix-1748-host-test: the own resolver's test reads the options from the catalogue's template ... 8dc186944e

TestTheCataloguesResolverComposesOnAMachine takes the options line from the systemd-resolved template beside it instead of the literal timeout:1 attempts:2 edns0, so it passes against the catalogue's main before and after the catalogue's change. Captured copies are left as they are.

Builds: design 50 resolver-wait §3 (and §2 of the main file, line 73)

mesh-tools commented 2026-11-12 17:20:24 +00:00

Author

Member

Copy Link

Copy Source

Delivery novox/mesh-host@8dc186944e7d — merged since 2026-11-12T17:52:57Z

Source — source.main moved to novox/mesh-host@0193949efe. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Group fix/1748-resolver-wait: novox/mesh-catalog@d22a7f3a41, novox/mesh-host@8dc186944e

Transitions

• 2026-11-12 17:20 (new) → proposed (announced): novox/mesh-host#225's head announced
• 2026-11-12 17:20 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
• 2026-11-12 17:52 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@8dc186944e7d` — **merged** since 2026-11-12T17:52:57Z **Source** — source.main moved to novox/mesh-host@0193949efe9f. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Group** `fix/1748-resolver-wait`: novox/mesh-catalog@d22a7f3a412f, novox/mesh-host@8dc186944e7d **Transitions** - 2026-11-12 17:20 (new) → proposed (announced): novox/mesh-host#225's head announced - 2026-11-12 17:20 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-12 17:52 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit 0193949efe into main 2026-11-12 17:52:55 +00:00

mesh-tools deleted branch fix/1748-resolver-wait 2026-11-12 17:52:56 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

mesh/ready

Reviewed and ready: mesh-delivery merges at the marked head once its checks pass (hq ADR 0364)

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

agent-ace agent-g14 agent-novox agent-shanks jschoubben mesh-tools miel.truyen nox-agent

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/mesh-host#225