A package manager that does not answer fails only the packages; the rest of the declaration applies (issue 233) #89

Closed
mesh-admin wants to merge 1 commits from fix/233-a-failed-probe-fails-only-what-needs-the-tool into main
Contributor

What

The pre-apply probe of the package manager (sys.Confirm) no longer refuses the whole declaration on arch and alpine. When pacman or apk does not answer, the node-engine says so before applying, applies everything else (files, units, accounts, its own upgrade), and every package resource fails with the probe's words. The system's PackageInstalled already asks the same probe first. The report names the probe under one stable key, the package manager (pacman), beside apply, so the controller can count it as one failure that goes on (the condition is in mesh-controller, same branch name). mesh-host apply by hand does the same and exits non-zero with "applied only in part" when no package was declared, and it never records known-good.

The android host still refuses whole. Its probe asks the system itself, which nothing the mesh declares can remove, and nothing else guards against the wrong machine.

Issue 234's generation check still runs before any of this. A declaration composed from an older view of the assignments is refused before anything is applied, as the decision of 2026-10-11 requires.

Why

On 2026-10-04 a declaration that left the package manager's module out removed pacman.conf. From then on, every declaration was refused whole for 90 minutes, including the one that would have written the file back and the node-engine's own upgrade. A person on the machine was the only way back. The decision recorded on the issue (2026-10-11): a failed probe fails only what needs the tool.

How it was tested

  • TestReplay233 (cmd/mesh-host/replay233_test.go) is the replay. A pacman on PATH answers as the workstation's did. The test sends a declaration with the configuration file plus a package through applyAndKeep, the link's path. It asserts that nothing was refused whole, the file is written and recorded, and the report carries the probe's words and the package. It uses only what the node-engine had before the fix: it fails on main (I watched it fail, "refused whole: this is the arch host and pacman does not answer here") and passes here.
  • The same test covers mesh-host apply by hand. A further test checks that with no package declared the apply is still said to be partial and the report names the package manager. Another checks that android still refuses whole.
  • sh merge-check.sh: green.

Overlap

PRs #87 and #88 (issue 358) also change cmd/mesh-host/main.go. This PR changes 4 small hunks there: the two Confirm calls in runApply and applyAndKeepHeld, the end of runApply and the report's Failed. They are far from #87/#88's hunks (usage text, the command switch and runLink's options), so git merges them without conflict. This PR does not touch internal/apply. The new logic is in cmd/mesh-host/probe.go.

Replay: R233 (cmd/mesh-host TestReplay233), to be registered in mesh-lab once this merges.

Fixes issue 233

## What The pre-apply probe of the package manager (`sys.Confirm`) no longer refuses the whole declaration on arch and alpine. When pacman or apk does not answer, the node-engine says so before applying, applies everything else (files, units, accounts, its own upgrade), and every package resource fails with the probe's words. The system's `PackageInstalled` already asks the same probe first. The report names the probe under one stable key, `the package manager (pacman)`, beside `apply`, so the controller can count it as one failure that goes on (the condition is in mesh-controller, same branch name). `mesh-host apply` by hand does the same and exits non-zero with "applied only in part" when no package was declared, and it never records known-good. The android host still refuses whole. Its probe asks the system itself, which nothing the mesh declares can remove, and nothing else guards against the wrong machine. Issue 234's generation check still runs before any of this. A declaration composed from an older view of the assignments is refused before anything is applied, as the decision of 2026-10-11 requires. ## Why On 2026-10-04 a declaration that left the package manager's module out removed `pacman.conf`. From then on, every declaration was refused whole for 90 minutes, including the one that would have written the file back and the node-engine's own upgrade. A person on the machine was the only way back. The decision recorded on the issue (2026-10-11): a failed probe fails only what needs the tool. ## How it was tested - `TestReplay233` (cmd/mesh-host/replay233_test.go) is the replay. A pacman on PATH answers as the workstation's did. The test sends a declaration with the configuration file plus a package through `applyAndKeep`, the link's path. It asserts that nothing was refused whole, the file is written and recorded, and the report carries the probe's words and the package. It uses only what the node-engine had before the fix: it fails on main (I watched it fail, "refused whole: this is the arch host and pacman does not answer here") and passes here. - The same test covers `mesh-host apply` by hand. A further test checks that with no package declared the apply is still said to be partial and the report names the package manager. Another checks that android still refuses whole. - `sh merge-check.sh`: green. ## Overlap PRs #87 and #88 (issue 358) also change `cmd/mesh-host/main.go`. This PR changes 4 small hunks there: the two `Confirm` calls in `runApply` and `applyAndKeepHeld`, the end of `runApply` and the report's `Failed`. They are far from #87/#88's hunks (usage text, the command switch and `runLink`'s options), so git merges them without conflict. This PR does not touch `internal/apply`. The new logic is in `cmd/mesh-host/probe.go`. Replay: R233 (cmd/mesh-host `TestReplay233`), to be registered in mesh-lab once this merges. Fixes issue 233
mesh-admin added 1 commit 2026-10-12 12:33:09 +00:00
Fail only the packages when the package manager does not answer, and apply the rest, so a later declaration can restore what an earlier one removed (issue 233)
mesh/delivery-group group fix/233-a-failed-probe-fails-only-what-needs-the-tool ready: every member ready, and composed together they pass
mesh/delivery stopped: the pull request closed unmerged
mesh/merge-gate pass: builds mesh-host → ace, g14, novox, shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed
cb0a07ba7a
Author
Contributor

Delivery novox/mesh-host@cb0a07ba7ac9 — stopped since 2026-10-12T12:50:43Z

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-host
  • ace: receives mesh-host
  • g14: receives mesh-host
  • novox: receives mesh-host
  • shanks: receives mesh-host
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine

Group fix/233-a-failed-probe-fails-only-what-needs-the-tool, in order: novox/mesh-host@cb0a07ba7a → novox/mesh-controller@2043b0273e

Transitions

  • 2026-10-12 12:33 (new) → proposed (announced): novox/mesh-host#89's head announced
  • 2026-10-12 12:38 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 12:38 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 12:50 ready → stopped (closed): the pull request closed unmerged

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-host@cb0a07ba7ac9` — **stopped** since 2026-10-12T12:50:43Z **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine **Group** `fix/233-a-failed-probe-fails-only-what-needs-the-tool`, in order: novox/mesh-host@cb0a07ba7ac9 → novox/mesh-controller@2043b0273edf - novox/mesh-host@cb0a07ba7ac9 before novox/mesh-controller@2043b0273edf: engine before controller - composed together: pass — every machine composes with the change as it did without (4 of 4 compose) **Transitions** - 2026-10-12 12:33 (new) → proposed (announced): novox/mesh-host#89's head announced - 2026-10-12 12:38 proposed → checked (checked): the verdict names this commit - 2026-10-12 12:38 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 12:50 ready → stopped (closed): the pull request closed unmerged The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at cb0a07ba

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host)
  • mesh/repo-check: PASS — its merge-check.sh passed

Delivery plan — builds mesh-host → ace, g14, novox, shanks; no bus step

  • tier 0: mesh-host
  • ace: receives mesh-host
  • g14: receives mesh-host
  • novox: receives mesh-host
  • shanks: receives mesh-host
  • grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine
  • read by no module's build: cmd/mesh-host/probe_test.go, cmd/mesh-host/replay233_test.go

Run by the build seat on shanks as build-1791808415774469828 (builds --log build-1791808415774469828).

--- the gate: mesh-host
mesh-host: ok
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 0
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-12T12:29:08Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mesh-host

notes:
  - cmd/mesh-host/probe_test.go and cmd/mesh-host/replay233_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	github.com/novox/mesh-host/cmd/mesh-bootstrap	1.011s
ok  	github.com/novox/mesh-host/cmd/mesh-host	5.674s
ok  	github.com/novox/mesh-host/examples	1.049s
ok  	github.com/novox/mesh-host/internal/accounts	1.593s
ok  	github.com/novox/mesh-host/internal/apply	4.906s
ok  	github.com/novox/mesh-host/internal/bootstrap	1.636s
ok  	github.com/novox/mesh-host/internal/bundle	1.041s
ok  	github.com/novox/mesh-host/internal/declaration	1.084s
ok  	github.com/novox/mesh-host/internal/firewall	1.867s
ok  	github.com/novox/mesh-host/internal/identity	1.132s
ok  	github.com/novox/mesh-host/internal/image	1.041s
ok  	github.com/novox/mesh-host/internal/inventory	1.046s
ok  	github.com/novox/mesh-host/internal/link	10.470s
ok  	github.com/novox/mesh-host/internal/liveness	2.129s
ok  	github.com/novox/mesh-host/internal/meshcli	1.589s
ok  	github.com/novox/mesh-host/internal/network	1.065s
ok  	github.com/novox/mesh-host/internal/outward	1.056s
ok  	github.com/novox/mesh-host/internal/profile	1.542s
ok  	github.com/novox/mesh-host/internal/reachable	1.056s
ok  	github.com/novox/mesh-host/internal/store	1.234s
ok  	github.com/novox/mesh-host/internal/system	1.056s
ok  	github.com/novox/mesh-host/internal/tunnel	1.060s
ok  	github.com/novox/mesh-host/internal/units	1.050s
ok  	github.com/novox/mesh-host/internal/upgrade	1.185s
ok  	github.com/novox/mesh-host/internal/witness	4.646s
ok  	github.com/novox/mesh-host/packaging	1.010s
?   	github.com/novox/mesh-host/rootsearch	[no test files]
ok  	github.com/novox/mesh-host/validate	1.009s
**Merge check** at `cb0a07ba` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mesh-host) - `mesh/repo-check`: **PASS** — its merge-check.sh passed **Delivery plan** — builds mesh-host → ace, g14, novox, shanks; no bus step - tier 0: mesh-host - ace: receives mesh-host - g14: receives mesh-host - novox: receives mesh-host - shanks: receives mesh-host - grants step: if this changes what the bus's user list says (a new tool, subject or user), novox is sent that list alone, every build there kept, before mesh-host is judged on its first machine - read by no module's build: cmd/mesh-host/probe_test.go, cmd/mesh-host/replay233_test.go Run by the build seat on shanks as `build-1791808415774469828` (`builds --log build-1791808415774469828`). ``` --- the gate: mesh-host mesh-host: ok long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 0 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-12T12:29:08Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-12T12:29:08Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mesh-host notes: - cmd/mesh-host/probe_test.go and cmd/mesh-host/replay233_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok github.com/novox/mesh-host/cmd/mesh-bootstrap 1.011s ok github.com/novox/mesh-host/cmd/mesh-host 5.674s ok github.com/novox/mesh-host/examples 1.049s ok github.com/novox/mesh-host/internal/accounts 1.593s ok github.com/novox/mesh-host/internal/apply 4.906s ok github.com/novox/mesh-host/internal/bootstrap 1.636s ok github.com/novox/mesh-host/internal/bundle 1.041s ok github.com/novox/mesh-host/internal/declaration 1.084s ok github.com/novox/mesh-host/internal/firewall 1.867s ok github.com/novox/mesh-host/internal/identity 1.132s ok github.com/novox/mesh-host/internal/image 1.041s ok github.com/novox/mesh-host/internal/inventory 1.046s ok github.com/novox/mesh-host/internal/link 10.470s ok github.com/novox/mesh-host/internal/liveness 2.129s ok github.com/novox/mesh-host/internal/meshcli 1.589s ok github.com/novox/mesh-host/internal/network 1.065s ok github.com/novox/mesh-host/internal/outward 1.056s ok github.com/novox/mesh-host/internal/profile 1.542s ok github.com/novox/mesh-host/internal/reachable 1.056s ok github.com/novox/mesh-host/internal/store 1.234s ok github.com/novox/mesh-host/internal/system 1.056s ok github.com/novox/mesh-host/internal/tunnel 1.060s ok github.com/novox/mesh-host/internal/units 1.050s ok github.com/novox/mesh-host/internal/upgrade 1.185s ok github.com/novox/mesh-host/internal/witness 4.646s ok github.com/novox/mesh-host/packaging 1.010s ? github.com/novox/mesh-host/rootsearch [no test files] ok github.com/novox/mesh-host/validate 1.009s ```
mesh-admin closed this pull request 2026-10-12 12:50:24 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-host#89