novox/mesh-lab
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Stage the sdk from its own checkout, not from a symlink that may not be one

Browse Source 
Both image scripts copied the runtime's installed tree and relied on the sdk
inside it being a link into the sibling repository. That is true only where
somebody linked them by hand, and false as soon as the dependencies are
installed the ordinary way — which fetches the sdk as sources with nothing
compiled. The image still built, and every entry point in it pointed at
nothing.
This commit is contained in:
jschoubben
2026-09-13 02:55:24 +02:00
parent e427e41389
commit 1ba237a634
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/build-module-runtime.sh
+10
View File
@@ -38,6 +38,16 @@ TSC="$MESH_SDK/node_modules/.bin/tsc"; ( cd "$MOD" && "$TSC" "${SRCS[@]}" --modu
STAGE="$(mktemp -d)"; trap 'rm -rf "$STAGE"' EXIT
cp -r "$MESH_TOOLS/dist" "$STAGE/dist"
cp -rL "$MESH_TOOLS/node_modules" "$STAGE/node_modules"
# And the sdk, from the sibling this script just built, whatever form the installed tree holds it
# in. It used to be relied on being a symlink into that sibling, which `-L` above materialised —
# true only on a workstation where somebody had linked them, and false the moment the runtime's
# dependencies are installed the ordinary way, which now fetches the sdk as sources with nothing
# compiled in it. The image built then looked fine and every entry point inside it pointed at
# nothing.
rm -rf "$STAGE/node_modules/@novox/mesh-sdk"
mkdir -p "$STAGE/node_modules/@novox"
cp -rL "$MESH_SDK" "$STAGE/node_modules/@novox/mesh-sdk"
rm -rf "$STAGE/node_modules/@novox/mesh-sdk/node_modules"
mkdir -p "$STAGE/modules/$MODULE"; cp -r "$MOD/dist" "$STAGE/modules/$MODULE/dist"
cp "$MESH_TOOLS/package.json" "$STAGE/package.json"
scripts/build-runtime-image.sh
+11 -1
View File
@@ -36,7 +36,17 @@ echo " module $AUDIT"
STAGE="$(mktemp -d)"
trap 'rm -rf "$STAGE"' EXIT
cp -r "$MESH_TOOLS/dist" "$STAGE/dist"
cp -rL "$MESH_TOOLS/node_modules" "$STAGE/node_modules" # -L materialises the @novox/mesh-sdk symlink
cp -rL "$MESH_TOOLS/node_modules" "$STAGE/node_modules"
# And the sdk, from the sibling this script just built, whatever form the installed tree holds it
# in. It used to be relied on being a symlink into that sibling, which `-L` above materialised —
# true only on a workstation where somebody had linked them, and false the moment the runtime's
# dependencies are installed the ordinary way, which now fetches the sdk as sources with nothing
# compiled in it. The image built then looked fine and every entry point inside it pointed at
# nothing.
rm -rf "$STAGE/node_modules/@novox/mesh-sdk"
mkdir -p "$STAGE/node_modules/@novox"
cp -rL "$MESH_SDK" "$STAGE/node_modules/@novox/mesh-sdk"
rm -rf "$STAGE/node_modules/@novox/mesh-sdk/node_modules" # -L materialises the @novox/mesh-sdk symlink
mkdir -p "$STAGE/modules/audit-logger"
cp -r "$AUDIT/dist" "$STAGE/modules/audit-logger/dist"
cp "$MESH_TOOLS/package.json" "$STAGE/package.json"