From e63459dd702ae6375816a28eaf4052d8056c6f5c Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 12 Oct 2026 18:37:30 +0200 Subject: [PATCH 1/2] Register R401: the send made a value for an own secret issued outside the mesh that nobody gave (hq issue 401) Proved: fails on mesh-controller 1e28342^1, passes on 1e28342 (the fix, #262). The replay is mesh-controller #274's TestReplay401, since the fix's own test reads what the fix added. --- replays/register.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/replays/register.go b/replays/register.go index b49a139..36ddeb9 100644 --- a/replays/register.go +++ b/replays/register.go @@ -389,6 +389,20 @@ var Register = []Replay{ Asserts: "a check judges the head merged into the trunk's head, and fails a head whose merge does not compile, " + "saying so", Package: "./internal/builder", Test: "TestReplay341", Files: []string{"internal/builder/replay341_test.go"}}, + // The mesh made a value for a secret only an outside party issues (2026-10-10): nobody had given the mounts + // module's smb-credentials, the send made a random value for it and placed it, and the module read it as a + // credential given and wrong (ADR 0228: such a secret is never made). The fix's own test reads what the fix added, + // so the replay is a test of its own in the controller, written with only what it had before the fix — register, + // assign, planFor, declarationFor, the inventory's secret reads — laid over the commit before. Needs a store: + // MESH_TEST_POSTGRES, as R237. Fix is the merge of its pull request (mesh-controller #262); Home is the commit that + // added the replay (mesh-controller #274), reachable once that pull request merges. + {ID: "R401", Issue: 401, Kind: InRepository, Repository: "mesh-controller", Fix: "1e28342edec170d59570e8127ddead7b19a70c20", + What: "the send made a random value for an own secret issued outside the mesh that nobody gave, and placed it: " + + "the module read it as a credential given and wrong", + Asserts: "the send makes no value for an own secret issued outside the mesh that nobody gave and places none, " + + "places no value the mesh made for it before, and places a value once a person gives one", + Package: "./cmd/mesh-controller", Test: "TestReplay401", Files: []string{"cmd/mesh-controller/replay401_test.go"}, + Home: "mesh-controller", HomeRef: "f3c15e00af5004d053bc424fe01c7f9a24656d59"}, } // Find is the replay of that id, or of that issue. From 3c655d83e11e0a53a93c3aa4c7bc09238db63db3 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 12 Oct 2026 19:01:18 +0200 Subject: [PATCH 2/2] Register R561: a plan's id was pasted into the SQL that reads it (hq issue 561) Proved: fails on mesh-controller f8daec0^1, passes on f8daec0 (the fix, #268). --- replays/register.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/replays/register.go b/replays/register.go index 36ddeb9..58d9e90 100644 --- a/replays/register.go +++ b/replays/register.go @@ -403,6 +403,17 @@ var Register = []Replay{ "places no value the mesh made for it before, and places a value once a person gives one", Package: "./cmd/mesh-controller", Test: "TestReplay401", Files: []string{"cmd/mesh-controller/replay401_test.go"}, Home: "mesh-controller", HomeRef: "f3c15e00af5004d053bc424fe01c7f9a24656d59"}, + // A plan's id was pasted into its query (2026-10-12): an id given to the plans verb holding a quote answered + // another plan, or failed as a syntax error. The fix's own test is a file of its own using only what the + // inventory had before (ForTest, SavePlan, PlanByID, RecentPlans), so it is laid over the commit before. Needs a + // store: MESH_TEST_POSTGRES. Fix is the merge of its pull request (mesh-controller #268). + {ID: "R561", Issue: 561, Kind: InRepository, Repository: "mesh-controller", Fix: "f8daec01d3f085ad30aa7fb584055d8d451c79dc", + What: "a plan's id was pasted into the SQL that reads it: an id holding a quote answered another plan, or " + + "failed as a syntax error", + Asserts: "an id holding a quote is read as a plain id: no plan answers it but one of that very id, and " + + "RecentPlans takes its limit as a parameter", + Package: "./internal/inventory", Test: "TestAPlanIdHoldingAQuoteIsReadAsAPlainId", + Files: []string{"internal/inventory/plan_id_test.go"}}, } // Find is the replay of that id, or of that issue.