novox/mesh-lab
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Take the resolver off before expecting a machine to leave the network

Browse Source 
mesh-resolver requires name resolution, which requires the network — so
unassigning the domain module alone leaves the machine on the network, pulled
back by its own requirement. The mesh was right and the test was wrong.

Which is the requirement graph doing its job: a module cannot quietly lose
something it depends on because somebody removed the thing that first brought
it in.
This commit is contained in:
jschoubben
2026-08-31 11:53:16 +02:00
parent cce39a6ba3
commit 622b414e4e
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/mesh.test.ts
+5 -1
View File
@@ -1342,6 +1342,11 @@ test("every name under a machine resolves to that machine", {
// It follows the machines. A node leaving the private network must stop being answered for,
// because a wildcard pointing at nothing resolves and then hangs — where an unresolvable name
// fails at once and says which name it was.
//
// Both, and that is not tidiness: `mesh-resolver` requires name resolution, which requires the
// network, so unassigning the domain module alone leaves the machine on the network — pulled
// back by its own requirement. The mesh was right and this test was wrong the first time.
await mesh("unassign laptop mesh-resolver");
await mesh("unassign laptop networking");
await mesh("push anchor");
await new Promise((r) => setTimeout(r, 15_000));
@@ -1354,7 +1359,6 @@ test("every name under a machine resolves to that machine", {
await mesh("assign laptop networking");
await mesh("unassign anchor mesh-resolver");
await mesh("unassign laptop mesh-resolver");
await mesh("push");
await new Promise((r) => setTimeout(r, 15_000));
});