An image the machine has no account for is handed over, not fetched
Deleting the lab's registry left the operator's own images to be pulled like anything else, and they cannot be: their registry wants an account and a scenario machine has none. The pull fails with 'no basic auth credentials', which is not something more patience fixes. So the test is no longer 'did the mesh build it' but 'can the machine get it at all'. Two ways to fail that — published nowhere, or published somewhere the machine cannot authenticate to — and one consequence: the workstation, which does hold the credential, exports it and loads it. Worth saying what this stands in for. In a finished mesh these are built by the builder and published to the mesh's own store, and every machine pulls them from there with a credential the mesh granted. Until that store exists there is nowhere for them to come from, and handing them over is the closest honest thing — not a registry the lab invents, which is what was just removed. Claude-Session: https://claude.ai/code/session_01LrgweAeERJYBg88c5cKDzF
This commit is contained in:
@@ -19,7 +19,7 @@ import { join } from "node:path";
|
||||
|
||||
import { incus, incusOk, succeeds } from "../incus/client.ts";
|
||||
import { around, log, shorten } from "../log.ts";
|
||||
import { isMeshBuilt, repositoryOf, type HeldImage } from "../pinning.ts";
|
||||
import { mustBeHandedOver, repositoryOf, type HeldImage } from "../pinning.ts";
|
||||
|
||||
/**
|
||||
* What this stage can put inside a machine.
|
||||
@@ -448,7 +448,7 @@ export async function loadHeldImages(
|
||||
// Refused by the validator, so reaching here would be a validator bug — but the consequence
|
||||
// is a third-party image quietly loaded from the workstation instead of pulled, which is the
|
||||
// fiction all of this exists to remove. Cheap to check, expensive to miss.
|
||||
if (!isMeshBuilt(requested)) {
|
||||
if (!mustBeHandedOver(requested)) {
|
||||
throw new Error(
|
||||
`images: '${requested}' is not one of the mesh's own images. It is pulled from the ` +
|
||||
`internet by the machine that needs it, not loaded from this workstation.`,
|
||||
|
||||
Reference in New Issue
Block a user