novox/mesh-lab
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

settled() asks which, not when

Browse Source 
The timestamp comparison lost the race between one test's closing push
and the next test's opening one: the old apply's report landed newer
than the new send and settled() passed for a declaration the machine
had not read. The report names its declaration now, the mesh says
whether it is the current one, and this reads the answer instead of
inferring it.
This commit is contained in:
jschoubben
2026-09-02 00:03:00 +02:00
parent a65115fc81
commit 81e5f31910
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/integration/mesh.test.ts
+6 -8
View File
@@ -135,7 +135,7 @@ async function settled(node: string, withinMs = 240_000): Promise<void> {
wrong: { node: string; outcome: string; refused?: string; wrong: { node: string; outcome: string; refused?: string;
failed?: { id: string; error: string }[] }[]; failed?: { id: string; error: string }[] }[];
waiting: { node: string; never: boolean }[]; waiting: { node: string; never: boolean }[];
reported: { node: string; outcome: string; at?: string; sent?: string }[]; reported: { node: string; outcome: string; current: boolean }[];
} | undefined; } | undefined;
let said = ""; let said = "";
try { try {
@@ -161,14 +161,12 @@ async function settled(node: string, withinMs = 240_000): Promise<void> {
.filter(Boolean).join("\n "); .filter(Boolean).join("\n ");
throw new Error(`${node} did not apply what it was sent (${bad.outcome}):\n ${why}`); throw new Error(`${node} did not apply what it was sent (${bad.outcome}):\n ${why}`);
} }
// Current is not caught up. The sent digest is recorded at send, so "not waiting" holds // Caught up is an equality, not an ordering. This compared timestamps once — report newer
// from the moment push returns, while the machine is still applying — this test asserted on // than send — and lost the race it invited: the previous test's closing apply reported
// containers the instant the declaration was current and found them not created yet. Caught // after this test's push, newer and still about the old declaration. The report now names
// up is the machine's own report being newer than what was sent to it: two timestamps the // the declaration it applied, and the mesh says whether that is the one it last sent.
// mesh recorded itself, compared.
const word = state.reported.find((r) => r.node === node); const word = state.reported.find((r) => r.node === node);
const acted = word?.outcome === "applied" && !!word.at && !!word.sent && const acted = word?.outcome === "applied" && word.current;
Date.parse(word.at) > Date.parse(word.sent);
if (!state.waiting.some((w) => w.node === node) && acted) return; if (!state.waiting.some((w) => w.node === node) && acted) return;
last = said; last = said;
// Unhurried on purpose: each poll is an exec into a container on the machine that is busy // Unhurried on purpose: each poll is an exec into a container on the machine that is busy