novox/mesh-lab
6
0
Fork 0
Code Issues Pull Requests 1 Releases Wiki Activity

Register R330: a message a consumer gave up on is kept (hq issue 330) #70

Merged
mesh-admin merged 2 commits from fix/330-a-message-given-up-on-is-kept into main 2026-10-08 19:27:04 +00:00
Conversation 1 Commits 2 Files Changed 1
+11
mesh-admin commented 2026-10-08 15:37:21 +00:00
Contributor
Copy Link
Copy Source

R330 replays hq issue 330: a consumer that never acknowledges an event gives it up, and the event is kept on the bus with its consumer, stream, subject, deliveries and when it was given up. A test in the controller (internal/link/replay330_test.go, mesh-controller#159).

Proved with go run ./replays/cmd/prove R330: PROVED, fails before its fix (a5f53ef), passes on it (75e567a). Fix is the pull request's head; Before is the main it is cut from, to be cleared once it merges.

Not touched: test/integration/events.test.ts still asserts the AMQP broker's dead-letter exchange, from before the bus moved to NATS; it does not run against today's bus.

merge-check.sh: passed locally.

Delivery group: fix/330-a-message-given-up-on-is-kept with mesh-controller, mesh-tools and hq.

R330 replays hq issue 330: a consumer that never acknowledges an event gives it up, and the event is kept on the bus with its consumer, stream, subject, deliveries and when it was given up. A test in the controller (`internal/link/replay330_test.go`, mesh-controller#159). Proved with `go run ./replays/cmd/prove R330`: PROVED, fails before its fix (a5f53ef), passes on it (75e567a). Fix is the pull request's head; Before is the main it is cut from, to be cleared once it merges. Not touched: `test/integration/events.test.ts` still asserts the AMQP broker's dead-letter exchange, from before the bus moved to NATS; it does not run against today's bus. merge-check.sh: passed locally. Delivery group: `fix/330-a-message-given-up-on-is-kept` with mesh-controller, mesh-tools and hq.
mesh-admin commented 2026-10-08 15:37:49 +00:00
Author
Contributor
Copy Link
Copy Source

Delivery novox/mesh-lab@f91164863bf6 — delivered since 2026-10-08T19:27:25Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-08 19:15 (new) → proposed (announced): novox/mesh-lab#70's head announced
  • 2026-10-08 19:16 proposed → checked (checked): the verdict names this commit
  • 2026-10-08 19:16 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-08 19:27 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-08 19:27 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-lab@f91164863bf6` — **delivered** since 2026-10-08T19:27:25Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-08 19:15 (new) → proposed (announced): novox/mesh-lab#70's head announced - 2026-10-08 19:16 proposed → checked (checked): the verdict names this commit - 2026-10-08 19:16 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-08 19:27 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-08 19:27 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-08 16:43:45 +00:00
Register R330: a message a consumer gave up on is kept (hq issue 330)
mesh/delivery superseded: a newer head of the same pull request
Details
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go)
Details
mesh/delivery-group group fix/330-a-message-given-up-on-is-kept delivering: 0 of 5 delivered
Details
54db7c3458
jschoubben force-pushed fix/330-a-message-given-up-on-is-kept from 18fb698de7 to 54db7c3458 2026-10-08 16:43:45 +00:00 Compare
jschoubben added 1 commit 2026-10-08 19:15:38 +00:00
Prove R330 against the merge of its fix
mesh/merge-gate pass: the change touches no module of the mesh's graph
Details
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (typescript), replays/merge-check.sh (go)
Details
mesh/delivery delivered
Details
f91164863b
mesh-admin merged commit 386e306642 into main 2026-10-08 19:27:04 +00:00
mesh-admin deleted branch fix/330-a-message-given-up-on-is-kept 2026-10-08 19:27:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jschoubben miel.truyen
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-lab#70