From 434bac93ceec897c17b4a605408dc38f42ce1397 Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 8 Oct 2026 10:44:39 +0200 Subject: [PATCH] Register the replay of issue 309 (hq ADR 0237) Proved with cmd/prove: TestReplay309 fails on the controller before c5a2edf (the group refused as a cycle) and passes on it. --- replays/register.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/replays/register.go b/replays/register.go index 298562a..f84c492 100644 --- a/replays/register.go +++ b/replays/register.go @@ -178,6 +178,16 @@ var Register = []Replay{ Asserts: "where the base branch holds a merge-check.sh, its script judges the change's tree, and a head " + "without one is never answered the warning", Package: "./internal/builder", Test: "TestReplay310", Files: []string{"internal/builder/replay310_test.go"}}, + // Two order rules ordered one pair both ways (2026-10-08): the controller's member moved the build agent, + // which builds the node-engine, and the node-engine goes before the controller, so the group + // feat/a-machine-joins-through-the-tunnel was refused as a cycle and merged by hand. A test in the + // controller, using only what orderOf had before its fix, laid over the commit before it. + {ID: "R309", Issue: 309, Kind: InRepository, Repository: "mesh-controller", Fix: "c5a2edf", + What: "a delivery group of the controller, the node-engine and the lab, each ready, was rejected: built by " + + "put the controller's member first and engine before controller put the node-engine's first", + Asserts: "rules that order one pair both ways are resolved by precedence — built by over engine before " + + "controller — and the group is ordered, the controller's member first", + Package: "./cmd/mesh-controller", Test: "TestReplay309", Files: []string{"cmd/mesh-controller/replay309_test.go"}}, // Not a core incident, and the first of its kind: a module's. The crash loop was found by a person // reading the agent server's log for another reason (issue 268); research 032 measured it, and ADR // 0240 makes the node-engine judge it and the gate fail it. -- 2.54.0